[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 12/19] xen/cpufreq: implement amd-cppc driver for CPPC in passive mode
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Mon, 11 Aug 2025 08:23:27 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XA+6qBJFfAcU6uUPUx/xX6ZfMwWuHXFgNARnbW/qYaM=; b=Q2tL/CeafFjnUuQ0W0bWHy7NAl6a378bjByDF4A3il2BdEfwiCr+KHGY6R+vY/ds00Fg9BqBB9KAurtfi7UqOECfdSNP6JYWqum87HXzYsV+i3hkfAEtD/8JdiTur/ZyTsl43mLU8FrHlHKsvjsV8BCeFSJBn2kJN2zFNo9Xgn2gl/97XRcGQmrgTMGK2Rot5Ua+J/L/8pBsD8N4ZQVCOHKy4GVdIRgdLF1sRCqEhEj3bfzu9AiyshT6Ll8NmZYlLwiG0hAhrMgIYDvTdxeE2r/4fXEfpWWmy+AmKMzKiacw/MHCHO8Yp9UX2LK31Pl2myH4AU5NhxmcLMjr3hXVXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tA2OlXwQ8tKOTKBpWzjrNJC+Yb2Vn4Kfd0sPziw0tn9qBAA21mFolZrCZ3DGzdUHc60cRk54Gn6SUvYn1Neg9axN2cCwhrFHib8H8nHwaKvMZw84BA/4PmUbM23iRByOb8NrHJiADIw1CHji9TcU1S758bFVjDOmrrwUq39Ak0tZkR17XhNR/Ob6WOO5vu40vk6HL1HEIAE3BJmpl2qiIiTiBZcbJ3KH9UPegSwNmZu01SIgnsl/kylM/M4VTUQ8TJOAQmhwLrvo2Q6tlYwuUuQJhGgjfIDwVm9SHjWfXFigFrm+bWW10mqG82kKv0g784HB+49qTJIb+/EuAeMcHg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 11 Aug 2025 08:23:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-08-11T08:23:21.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHb8hcm/2j2N+pZoEenN2J+6s0qPrQ2T+AAgCb91HA=
- Thread-topic: [PATCH v6 12/19] xen/cpufreq: implement amd-cppc driver for CPPC in passive mode
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, July 17, 2025 8:55 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 12/19] xen/cpufreq: implement amd-cppc driver for CPPC
> in passive mode
>
> On 11.07.2025 05:50, Penny Zheng wrote:
> > --- a/xen/arch/x86/acpi/cpufreq/amd-cppc.c
> > +++ b/xen/arch/x86/acpi/cpufreq/amd-cppc.c
> > + if ( res < 0 )
> > + {
> > + printk_once(XENLOG_WARNING
> > + "Perf value smaller than minimum value 0: %d\n", res);
> > + *perf = 0;
> > + return 0;
> > + }
> > + *perf = res;
>
> Considering that amd_cppc_init_msrs() rejects perf values of 0 as invalid, is > 0
> actually valid as an output here?
>
Yes... we are rejecting 0 in there. Maybe I shall return -ERANGE here instead
> Jan
|
