[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 1/5] vpci: Use cleanup to free capability resource during deassign
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Mon, 11 Aug 2025 04:04:57 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w18p9Hmn8xl43ty+RobpzmMHh/4kV2nLidd4zqdEpxY=; b=Y+UjqKrIBleRlQi15B/iJOzfsDB8Hz7MUZljBcqlS7/I60w7I8TnejTlAigJ1VenZuvzLXqHKJAfviFEihGkuPA5qnX04Qb2I6ebI8i5HxMzr3NIsBj8C8R7YY1YQt0HqY8tpjRW5DX6zmkmN1NuKCaxAlaBspCntWKLgh23ZodW04CebrfJ1M+7eiMPNtiqavf3yYly6DkDWfWkxWAjUczAdvMHxZOOqlKl1hqv2HECdXZ40f/cdNBKknDLI1UtvzgdPKLOvzdLQ5u8gRPbr6s7cQrvvXkDX0kLD9czV3l9dWcDPGJBv6Lb2MluPIXsX8v8djwojRh0wzwOZf+ZQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eUme0jmvhkKzrKJpMOmk6TffDb1t+sJpTVVb/+8NX5eXQO1aaxR8BJB0lr5sXjVDrzNcbIr4xfYHHiGjoWvMiNIfAvTXKUX0VCt/NhXRPcQWY32XM4PxSySUk8pn+Q/VYlxdoiDiNB7D1prKoFCk362DXZqQTBhHrhGVm3NJRI79Dd/1PZbAqgaNuX8z1Z+qzzJBp1FkMBS2MdzTg3LLcQj6o7iWJ4Wme7hu63jDExRumj8xlhsSSPaxgK1fzSDtoLcIGy0lL08wu8VVc2/vye5/JhUnWCfCnOHxgLkJVCiEKT4wrEJioF8yXu1JjHUehhhOr9T3qgBAYIak6v5XUA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 11 Aug 2025 04:05:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcCDr/CaLOehn+20Smgxu8slgKHbRYdKKAgATqx4A=
- Thread-topic: [PATCH v11 1/5] vpci: Use cleanup to free capability resource during deassign
On 2025/8/8 16:58, Jan Beulich wrote:
> On 08.08.2025 10:03, Jiqian Chen wrote:
>> @@ -321,6 +321,29 @@ void vpci_deassign_device(struct pci_dev *pdev)
>> &pdev->domain->vpci_dev_assigned_map);
>> #endif
>>
>> + for ( i = 0; i < NUM_VPCI_INIT; i++ )
>> + {
>> + const vpci_capability_t *capability = &__start_vpci_array[i];
>> + const unsigned int cap = capability->id;
>> + unsigned int pos = 0;
>> +
>> + if ( !capability->cleanup )
>> + continue;
>> +
>> + if ( !capability->is_ext )
>> + pos = pci_find_cap_offset(pdev->sbdf, cap);
>> + else if ( is_hardware_domain(pdev->domain) )
>> + pos = pci_find_ext_capability(pdev->sbdf, cap);
>> + if ( pos )
>> + {
>> + int rc = capability->cleanup(pdev, false);
>> + if ( rc )
>
> Nit: Blank line between declaration(s) and statement(s) please. (Likely
> easy enough to adjust while committing, if no other need for a v12
> arises.)
Thanks.
BTW, do I need for-4.21 flag if I expect this series to be merged before 4.21
release?
>
> Jan
--
Best regards,
Jiqian Chen.
|
