Re: [PATCH v14 3/4] tools/tests: introduce unit tests for domain ID allocator

[dmkhn@xxxxxxxxx]

On Fri, Aug 08, 2025 at 06:57:07PM +0100, Julien Grall wrote:
> 
> 
> On 08/08/2025 18:56, Julien Grall wrote:
> > Hi Denis,
> >
> > On 08/08/2025 03:20, dmkhn@xxxxxxxxx wrote:
> >> From: Denis Mukhin <dmukhin@xxxxxxxx>
> >>
> >> Introduce some basic infrastructure for doing domain ID allocation
> >> unit tests,
> >> and add a few tests that ensure correctness of the domain ID allocator.
> >
> > I am quite happy to see more unit tests for Xen :).
> >
> >>
> >> Use <xen-tools/bitops.h> and xen/lib/find-next-bit.c in test hardness
> >> code.
> >>
> >> Adjust find-next-bit.c to be compiled with __XEN_TOOLS__.
> >>
> >> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > With a couple of remarks below:
> >
> > Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Actually, this should have been a Reviewed-by tag. Sorry.

Thanks for review!

> 
> Cheers,
> 
> --
> Julien Grall
>