Re: [PATCH v1 08/16] kmsan: convert kmsan_handle_dma to use physical addresses

[Jason Gunthorpe <jgg@xxxxxxxxxx>]

On Mon, Aug 04, 2025 at 03:42:42PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
> 
> Convert the KMSAN DMA handling function from page-based to physical
> address-based interface.
> 
> The refactoring renames kmsan_handle_dma() parameters from accepting
> (struct page *page, size_t offset, size_t size) to (phys_addr_t phys,
> size_t size). A PFN_VALID check is added to prevent KMSAN operations
> on non-page memory, preventing from non struct page backed address,
> 
> As part of this change, support for highmem addresses is implemented
> using kmap_local_page() to handle both lowmem and highmem regions
> properly. All callers throughout the codebase are updated to use the
> new phys_addr_t based interface.

Use the function Matthew pointed at kmap_local_pfn()

Maybe introduce the kmap_local_phys() he suggested too.

>  /* Helper function to handle DMA data transfers. */
> -void kmsan_handle_dma(struct page *page, size_t offset, size_t size,
> +void kmsan_handle_dma(phys_addr_t phys, size_t size,
>                     enum dma_data_direction dir)
>  {
>       u64 page_offset, to_go, addr;
> +     struct page *page;
> +     void *kaddr;
>  
> -     if (PageHighMem(page))
> +     if (!pfn_valid(PHYS_PFN(phys)))
>               return;

Not needed, the caller must pass in a phys that is kmap
compatible. Maybe just leave a comment. FWIW today this is also not
checking for P2P or DEVICE non-kmap struct pages either, so it should
be fine without checks.

> -     addr = (u64)page_address(page) + offset;
> +
> +     page = phys_to_page(phys);
> +     page_offset = offset_in_page(phys);
> +
>       /*
>        * The kernel may occasionally give us adjacent DMA pages not belonging
>        * to the same allocation. Process them separately to avoid triggering
>        * internal KMSAN checks.
>        */
>       while (size > 0) {
> -             page_offset = offset_in_page(addr);
>               to_go = min(PAGE_SIZE - page_offset, (u64)size);
> +
> +             if (PageHighMem(page))
> +                     /* Handle highmem pages using kmap */
> +                     kaddr = kmap_local_page(page);

No need for the PageHighMem() - just always call kmap_local_pfn().

I'd also propose that any debug/sanitizer checks that the passed phys
is valid for kmap (eg pfn valid, not zone_device, etc) should be
inside the kmap code.

Jason