[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/HVM: polish hvm_asid_init() a little


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Tue, 5 Aug 2025 11:30:58 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tFEV+eaLF0XRM9fi1aEPR912nYi2HAOu0w8fh8HAiWo=; b=nK/uE3JNurqI1vhe5I/lm5R1NkEpGWwo3r1Si31+jdTj+bkNZ8TltAxLx3yietQaYAgp4jNJak8PaT/SVECANWllT7gs8WsVGl7WVjzUpDDD2PASKCgYLR31hI9vUbp6uA/BGUOZx9M/NK1BnUx6HPqMN2dT98GcDolUnTlq6sKxRP5XOHADq8YHNk41PK1fs5kUuneiw+CnAGhENqEEooJaCBlEp9GqsCZqNqfoUsnysjxQ7iTpbxshxe1+3ScPCAKPR4FPYTlgIgKNSueenyjyeCkMWtfpa9hPfxiKsrDeYl+ui+ro+zd8GmPnldm6kkaST3UN+7a3NcmAekF7eA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z5nhKKia2GpQfRbCrQr2QbXVkzY7pHsC7NYHCTIMBw6nQOkxXZv8FO4Kxa55d56qyteZNSByv7iEBh5NapqxjKcB9/RLbEprOUAOJyZC3vAWxJYuGKpIrQ1lgmTpl5hn3qZVDbVZxn+Um9jrER70EqWjJqOyWv6QmnQNKad/GhvatYu++ZDZA56S00br9Lt992ou4AlIK2PwcWeONJscmccmxwEvjPYavrmIAaYCIudgvENfUua8mLiX9rGt7X9zWRgJPnYEfSPjNb71rMTFWiex9xpbcemrMMqaPkX3zbdnaEZFvFwGySSoYD0R6QwgZWlneYaOMsS46kk9Vz43Mg==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 05 Aug 2025 15:31:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-08-04 11:41, Jan Beulich wrote:
While the logic there covers asymmetric cases, the resulting log
messages would likely raise more confusion than clarify anything. Split
the BSP action from the AP one, indicating the odd CPU in the AP log
message, thus avoiding the impression that global state would have
changed.

While there also
- move g_disabled into .data.ro_after_init; only the BSP will ever write
   to it,
- make the function's parameter unsigned; no negative values may be
   passed in. Also reflect this in svm_asid_init().

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.