[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 01/25] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Tue, 5 Aug 2025 03:38:46 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86mT8uL4FvixMVJuXxW4Wj/wwv2wlMHOKFATAOBdTwQ=; b=hBhZn8EF3BPqexBNbif8mxhn1tABgxMM6CDrkZthgWG4G40bDL7dR9DvOXIV7PVQmpIlegT33Iftsa0oKoZH19LiuTPnB2lVcL46Bl1a8sn2qcFBIoSF9AoUC5xi8J5hiYprf1dp6ikDll2tiFxg4dE+AWBKUXo3BLo8nZ425hMxnArvt7wUNFYDtECQ4n72ZIb42I1RlidvNHzOpMFWSixIvsPanz6Y2mNlUo6nM4txRE1rYtpaAHdWN/OgjeQn/gFzyYZNkwU2C/c8ami2sttsKBq9N4EDyGsS3xLN0RHQjKiG9clXBjhtVuIlcjHm5wi8UBy8niOhPvXiP5cj7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u+P1l2skQb/+MPoHaDQ9E6iTp2YDdI6LlRXjWSMkfcH62k/zvW1YFdvbpWSaJgRj4rTQAb2T6gFsPeLCiEXOBElJALz7QgF6egm0zWX8AhyZGsiqYlYArp95Pg0kk3fppUaetIkKjE8vNJECg2ApAj/3CFestJ1Atmuiqf8nVXz0TVQOJ0snZhCccmZN/HsmO4ocyMM2VsckF1hSlUAwZE1mQBMTbJ0snG1FeJc2e9YyejG/R4QE4a26P0hZ7eKFdv8iiH5UWX2I7OwUOP+iEcnOKk5vm8XO87A4IepBA6cH0GE//Nhbf7PIpko0LNiMhOq+8mjt1/QtcAv6z7jSkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 05 Aug 2025 03:39:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-08-05T03:38:18.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHcBFu8ZJDiUyPinUSx+WVIYPWedrRSHgaAgAAiBnA=
- Thread-topic: [PATCH v1 01/25] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, August 4, 2025 3:43 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 01/25] xen/x86: move domctl.o out of
> PV_SHIM_EXCLUSIVE
>
> On 03.08.2025 11:47, Penny Zheng wrote:
> > In order to fix CI error of a randconfig picking both
> > PV_SHIM_EXCLUSIVE=y and HVM=y results in hvm.c being built, but
> > domctl.c not being built, which leaves a few functions, like
> > domctl_lock_acquire/release() undefined, causing linking to fail.
> > To fix that, we intend to move domctl.o out of the PV_SHIM_EXCLUSIVE
> > Makefile /hypercall-defs section, with this adjustment, we also need
> > to release redundant vnuma_destroy() stub definition and paging_domctl
> > hypercall-defs from PV_SHIM_EXCLUSIVE guardian, to not break
> > compilation Above change will leave dead code in the shim binary
> > temporarily and will be fixed with the introduction of CONFIG_DOMCTL.
> >
> > Fixes: 568f806cba4c ("xen/x86: remove "depends on
> > !PV_SHIM_EXCLUSIVE"")
> > Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
> > ---
> > v1 -> v2:
> > - remove paging_domctl hypercall-defs
>
> And you've run this through a full round of testing this time, in isolation?
>
This commit shall be committed together with "xen/x86: complement PG_log_dirty
wrapping", (I've added in change log, idk why it didn't get delivered in the
mail list in the last).
As PG_log_dirty is disabled on PV mode, paging_domctl() will still have
"undefined reference" on PV mode, which gets fixed in "xen/x86: complement
PG_log_dirty wrapping". I thought it better sits there.
If it doesn't comply with the commit policy, I'll move according fix here.
> Jan
|
