Re: [XEN][PATCH 3/3] xen/riscv: irq: drop unreachable pirq callbacks

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 8/1/25 12:08 PM, Grygorii Strashko wrote:

> From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
>
> Hence all common pIRQ code is under CONFIG_HAS_PIRQ idefs corresponding
> RISCV arch pIRQ callbacks become unreachable, so drop them.
>
> Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
> ---
>  xen/arch/riscv/stubs.c | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/xen/arch/riscv/stubs.c b/xen/arch/riscv/stubs.c
> index 8918cebf35c6..1a8c86cd8da2 100644
> --- a/xen/arch/riscv/stubs.c
> +++ b/xen/arch/riscv/stubs.c
> @@ -82,26 +82,6 @@ void smp_send_call_function_mask(const cpumask_t *mask)
>  
>  /* irq.c */
>  
> -struct pirq *alloc_pirq_struct(struct domain *d)
> -{
> -    BUG_ON("unimplemented");
> -}
> -
> -int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share)
> -{
> -    BUG_ON("unimplemented");
> -}
> -
> -void pirq_guest_unbind(struct domain *d, struct pirq *pirq)
> -{
> -    BUG_ON("unimplemented");
> -}
> -
> -void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask)
> -{
> -    BUG_ON("unimplemented");
> -}
> -
>  void irq_ack_none(struct irq_desc *desc)
>  {
>      BUG_ON("unimplemented");
>     
LGTM: Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

~ Oleksii