[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Sun, 3 Aug 2025 09:51:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31vOr+6hkU+kjHdDMaaud8RR0o+tMZNmuY0vWAWTTFM=; b=VjGauDdt2vPtdCzMdiU/eTNFhjUUyHavqxQI8LfyBMBs4mb7Ri96WUtUojJtqMMdU5HOILGTBAt3KcSGwD+U3uI4f2eDrrsnHQ8Kdn7fdCxcxE8/U0NcajIUZzUhtutKlKfzK72+kkQADQNmVz/yzmvbWbbaXaNOGYNPADNtNHxjGmaV4+f8066GqgaQVErx6IeKflV9bkMwcS6lKIS+Y0/ON7HsFZohtiWGQvEpERItf7zorDenQhtTMWb329J1wurg5w+jCZgoE+0evTuPGPriKYB/+6+FZ8rzdquTKXyGBlp8iTVRciOat+8D0g0uWFDmu4azy9M1RJ3J7DRSCw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e8EYFC4xu2bWWkLLDEEhKNV/29IogtOM0iD1aGF+P7rmg3yuC2nzESSG6sA8ZLrn7rcWaTnlIFmewKYHv303XFV4QGMsw7Pja0JLBEzfEBY+GW3nManEzn72veYseBxiEN05S5LTgwETt1TgKZ/diKY8SIcpzFjL09/17oFfwE1xt4Yi660hw4xYxLl7cLlSz7wNX660ScqSGzJxuuejDHTk82yhSyFcSIuQPglkvEGUl5ueG+MZaAdHvchPxDItFIYGsuP+0a5AIwwCZkNVfiW5WS7wMwkblScKRWpQKbJswn+6lMtNt2bNkiRcx0bLZh8QqlxCVIG2g1nnfmizlw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>
- Delivery-date: Sun, 03 Aug 2025 10:02:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-08-03T09:50:54.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHb/S2yWmLQISYx7E+NkBDkce1BCbRI8U4AgAfL0xA=
- Thread-topic: [PATCH v1] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, July 29, 2025 6:45 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné
> <roger.pau@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel,
> Michal <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> Stabellini,
> Stefano <stefano.stabellini@xxxxxxx>
> Subject: Re: [PATCH v1] xen/x86: move domctl.o out of PV_SHIM_EXCLUSIVE
>
> On 25.07.2025 08:30, Penny Zheng wrote:
> > In order to fix CI error of a randconfig picking both
> > PV_SHIM_EXCLUSIVE=y and HVM=y results in hvm.c being built, but
> > domctl.c not being built, which leaves a few functions, like
> > domctl_lock_acquire/release() undefined, causing linking to fail.
> > To fix that, we intend to move domctl.o out of the PV_SHIM_EXCLUSIVE
> > Makefile /hypercall-defs section, with this adjustment, we also need
> > to remove redundant vnuma_destroy() stub definition to not break
> > compilation.
> > Above change will leave dead code in the shim binary temporarily and
> > will be fixed with the introduction of CONFIG_DOMCTL.
> >
> > Fixes: 568f806cba4c ("xen/x86: remove "depends on
> > !PV_SHIM_EXCLUSIVE"")
> > Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
>
> It seems pretty clear that this patch is what causes
>
> ld: prelink.o: in function `arch_do_domctl':
> (.text+0x5b85d): undefined reference to `paging_domctl'
> (.text+0x5b85d): relocation truncated to fit: R_X86_64_PLT32 against undefined
> symbol `paging_domctl'
> ld: ./.xen-syms.0: hidden symbol `paging_domctl' isn't defined
> ld: final link failed: bad value
>
> throughout the various build jobs in CI. Considering prior issues I feel
> urged to
> ask whether you actually tested your change.
>
So sorry, I tested it with my whole domctl patch serie and the error got hidden.
I re-sent it in the head of domctl patch serie and tested it in his own.
> Jan
|
