[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xenalyze: correct symbol name length fscanf() specifier
On Mon, Jul 28, 2025 at 07:08:46PM +0200, Alejandro Vallejo wrote: > On Mon Jul 28, 2025 at 5:52 PM CEST, Jan Beulich wrote: > > SYMBOL_NAME_SIZE is 124, not 128. Use the symbolic name there as well, > > to avoid any disconnect. > > > > While there correct indentation on the following line as well. > > > > Coverity ID: 1659391 > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > --- > > There's no useful Fixes: tag; the code was imported from HG this way > > about 10 years ago. > > > > --- a/tools/xentrace/xenalyze.c > > +++ b/tools/xentrace/xenalyze.c > > @@ -321,11 +321,10 @@ void parse_symbol_file(char *fn) { > > (*p)->next=NULL; > > } > > > > - /* FIXME -- use SYMBOL_NAME_SIZE */ > > /* FIXME -- use regexp. This won't work for symbols with spaces > > (yes they exist) */ > > (*p)->symbols[(*p)->count].addr = 0xDEADBEEF; > > - if ( fscanf(symbol_file, "%llx %128s", > > - &(*p)->symbols[(*p)->count].addr, > > + if ( fscanf(symbol_file, "%llx %" STR(SYMBOL_NAME_SIZE) "s", > > nit: A comment at the #define stating it's used this way would prevent future > "oops" situations when/if someone tries to do (e.g) "#define SYMBOL_NAME_SIZE > (1 > << 4)" > > Though arguably that would cause a compile-time error anyway (except perhaps > an octal literal?), so meh. With or without the adjustment: > > Reviewed-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Thanks, -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |