[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v5 10/11] tools/xenstored: Remove stubdom special casing


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 25 Jul 2025 19:58:57 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+kKFCNFyptcpiw4lFRKhcWH6qMRw/y7Ho+2rz52PFhI=; b=t81fjirudYbHdSnlZwUGZ7GYxPcebSHm4ad1ZaN2rk+8TWzcEhpmCY1UvNcitO8HkhqG/mVbwAjONpp3BlENy7xef4PVxRbYPJOiTXiI61ewYxQT0xebCpdB4llM+SNUQ83oB/Xq21GTphUVsSP2CkgG9YTAmF+z88bUcpCPSCk2EVp6+hNLxOEBBC78k0xmzKkxTLMUyAgkXsMy4PoCFBLjjdgbc1eF/OfccqTHd8tY4wkh27FgSwHWB0eDS6CrWDHPW3TqiuvmHnopbBKmjvYbOI17HUhABTWmF9yxbm6Z9pclPWj79klNRjRA1ZzTnIwwvrthUjwZ40X3iBgsTw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CQj3mm8BEdYL2oHmAC31tzW/DHBd0P/7xheiqZpKHSMlf9rBU5PIC6eToqahPDWX43N0MQVJ2naG+406ZmKQS/eXqDJtaXc9mz4dgo89dbVfsbk7JN8pZuk50z2EyYkoZpD0sEsjNmLPZLKUQ5Ft8A5oXzj0HGqnDJ4tkkGjUg28NguCtNRDNI3GIbBuekC8n46kvMYJTypfxSGwdHL2ZzKyykumMlToi1sQtZQqa7/keIobUGfBjlWu852WDDZ3mxfXM5y7EavQ0RXG1BrzLy2dbgB1QNy4pFzvBlTivIzQtSg4b+T/m1p0K9VvWSBjYUwcngBQHgLt2njlaqiwFQ==
  • Cc: Jason Andryuk <jason.andryuk@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 25 Jul 2025 23:59:48 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

posix.c and minios.c implement the same named functions serving slightly
different purposes.

For xenbus_map()
posix.c maps the local /dev/xen/xsd_kva
minios.c maps dom0 via grant and there is open coding for stub_domid in
map_interface.

Change xenbus_map() to map the local domain's interface.  The default
grant table mapping is performed otherwise.

Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
v5:
Re-order later
---
 tools/xenstored/domain.c | 5 -----
 tools/xenstored/minios.c | 4 +---
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c
index 2f79db26df..be8dd19eb8 100644
--- a/tools/xenstored/domain.c
+++ b/tools/xenstored/domain.c
@@ -506,11 +506,6 @@ static void *map_interface(domid_t domid)
        if (domid == store_domid)
                return xenbus_map();
 
-#ifdef __MINIOS__
-       if (domid == stub_domid)
-               return xenstore_buf;
-#endif
-
        return xengnttab_map_grant_ref(*xgt_handle, domid,
                                       GNTTAB_RESERVED_XENSTORE,
                                       PROT_READ|PROT_WRITE);
diff --git a/tools/xenstored/minios.c b/tools/xenstored/minios.c
index a86edbd5c8..54230796b5 100644
--- a/tools/xenstored/minios.c
+++ b/tools/xenstored/minios.c
@@ -61,13 +61,11 @@ evtchn_port_t get_domain_evtchn(unsigned int domid)
 
 void *xenbus_map(void)
 {
-       return xengnttab_map_grant_ref(*xgt_handle, xenbus_master_domid(),
-                       GNTTAB_RESERVED_XENSTORE, PROT_READ|PROT_WRITE);
+       return xenstore_buf;
 }
 
 void unmap_xenbus(void *interface)
 {
-       xengnttab_unmap(*xgt_handle, interface, 1);
 }
 
 void early_init(bool live_update, bool dofork, const char *pidfile)
-- 
2.50.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.