[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] tools/xenstored: add server feature support
- To: Jürgen Groß <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 25 Jul 2025 08:35:55 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bKTT7P1w9ynPZynKGyP5ykIsXF9168p88SZZONY9UBg=; b=WjF9UPFbQ8SuX7ySbND96+P9WFZHNJzfy+KCGXIbuoeVnFleW+1N27eocauAoV21+k4KycwMUsotzz58hvMQYhJHiSEfq5OMsj6hwctTJRY4V3LVa3+5mU30dXOp8xuii8riYI/Vd9tNp6o2D/m9VTkdEGZx2mzdCh0cPXNJidLL3BFkBLinL7Lg0587H58JDh7x3K4KIBW34O3PU7k/SdFbUT7JoXkuYNFKvA74qFMZVGzUfu7JOkrQ4Ho9cJJ7GauRhVnxND0o7pfUzmM9iJ7yG3iti0xPnm/pUwjvlrmiWlP6JdG3SItVsKUMizjrbQU05+VbUa2hBU1Qa0Do5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IeKEUN/Akz9HMzcQny0GrM79WL3iIqu9M97vGkeRIGi6uCetXc1yxV/jafH+XxVqL65KnOzJdd6cmtoXU8DYItztaF/f6R2NDYixGXSkY89QWJ6LcFlrCD564pa0e1wNT0vsjwX3/rfFQovRa0CBv50rBFEOwGp4NccwbHjmEtWu6oYSRple5T7dCbVOIXvLgGBiStnp8VOggsMU/J2toUjXuzLhBU5VN/Lh6UWAK7FUmju6wMih6Hq1C3z4qADLV87uoLps/SAyjVsMzGYgn/d01BE1tiQ3RmCk8RcnShvq24oEYFDfdb6GXgqNdkJow4g7ctf/xeJvpxryu7I2hA==
- Cc: Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 25 Jul 2025 12:36:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-07-25 01:18, Jürgen Groß wrote:
On 25.07.25 00:48, Jason Andryuk wrote:
On 2025-07-22 10:06, Juergen Gross wrote:
Add per domain server features, which are initialized by the supported
features at domain introduction, or by live update from the migration
stream. This requires to add the DOMAIN_DATA record to the migration
stream, but for now it will only contain the feature word.
Advertise the Xenstore features to guests by setting the appropriate
bits in the ring page.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
+static int dump_state_domain(const void *k, void *v, void *arg)
+{
+ struct domain *domain = v;
+ FILE *fp = arg;
+ struct xs_state_domain sd;
+ struct xs_state_record_header head;
+
+ head.type = XS_STATE_TYPE_DOMAIN;
+ head.length = sizeof(sd);
+ memset(&sd, 0, sizeof(sd));
+ sd.domain_id = domain->domid;
+
+ if (lu_status->version > 1)
Is this why you expose lu_state below? I can't find any other use.
Yes.
Are you guaranteed lu_status != NULL?
Yes, we are already writing out the data for the new Xenstore instance,
so lu_status must have been setup.
Ah, right.
This looks good to me, but with server_feature assignment movement, I'll
wait for the next version.
Thanks,
Jason
|
