[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 18/19] xen/cpufreq: bypass governor-related para for amd-cppc-epp
- To: Penny Zheng <Penny.Zheng@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Thu, 24 Jul 2025 18:36:01 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ow3+k6oDixko6EciNj0nOsVReK131xnYJn/jXMYNvvQ=; b=lICtOyHTmhQEttMbALNAoYNSXdFHRSXoBNPH+lY8N5oRqaYQXe7+ZNLXd5CKoXSc3ll4QBDRANvcC9r+ayj4HgTD+ZOaoC5KF4+pl5s0h6d9+cNBMj+FaY5fe8F3RUjg4phvykQjzFqUpI+2CC8FfR2z89imxvRpH8qnouiPpWt82GcKfNQ/XilEUqWX2bsVsF3SnExTHa9SGTOn9LOnbdmy1Otto83+Hr2a14Riv1SZH8LjDofbeQKsTWGcLOVbqijyMzsnym0qOMQWyJ1M/awfGp+mP5PK0K5x4a3gnM0p4zpMFxhTZmPejwVt4cRoCyetmYox7j41dxDpcwMsjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mpol2Psy5ZV+k5eZJBqca3kdtLaz/CssYVwG6PwrodqQEgGxGPSeBScaetWw8ScWGlxdIM1urPoIbwvam43ud+/YILnf5SW1L9WuaW72BLnjtBms91pCy1XEgB+35cpdTyU/W3Bm+OC/QsvzHBGz0U3zvkXksiQRttsDlKBd24A49c+VpWKdfaj19PyHyopC2V+2xuoEqgsyi5q6YnNTeGXdm7R0TU60CkzcvXygmABQq7p5GGBOYtwQkdYu68jyB9ohV8t3ZpXyCSb9DrCw84CpBord7YXOm/wr6uck5h2IlXqU4JWhaaxF9uWwvjMQygJblrL2xghMfc66hFmqww==
- Cc: <ray.huang@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>
- Delivery-date: Fri, 25 Jul 2025 00:19:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-07-10 23:51, Penny Zheng wrote:
HWP and amd-cppc-epp are both governor-less driver, so we introduce "hw_auto"
flag to together bypass governor-related print in print_cpufreq_para().
In set_cpufreq_para(), a new helper is introduced to help error out when
cpufreq core intialized in governor-less mode.
---
v3 -> v4:
- Include validation check fix here
---
v4 -> v5:
- validation check has beem moved to where XEN_PROCESSOR_PM_CPPC and
XEN_CPPC_INIT have been firstly introduced
- adding "cpufreq_driver.setpolicy == NULL" check to exclude governor-related
para for amd-cppc-epp driver in get/set_cpufreq_para()
---
v5 -> v6:
- add helper cpufreq_is_governorless() to tell whether cpufreq driver is
governor-less
---
diff --git a/xen/drivers/acpi/pm-op.c b/xen/drivers/acpi/pm-op.c
index 077efdfc5c..54815c444b 100644
--- a/xen/drivers/acpi/pm-op.c
+++ b/xen/drivers/acpi/pm-op.c
@@ -244,8 +244,8 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op)
if ( !policy || !policy->governor )
return -EINVAL;
- if ( hwp_active() )
- return -EOPNOTSUPP;
+ if ( cpufreq_is_governorless(op->cpuid) )
+ return -EOPNOTSUPP;
NIT: return indent off by 1.
Regards,
Jason
switch( op->u.set_para.ctrl_type )
{
|
