Re: [PATCH v2] x86/hvm: Replace do_sched_op calls with their underlying logic

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Le 23/07/2025 à 13:16, Andrew Cooper a écrit :
> On 23/07/2025 10:05 am, Teddy Astie wrote:
>> do_sched_op(SCHEDOP_yield) just calls vcpu_yield(). Remove the indirection
>> through the hypercall handler and use the function directly.
>>
>> Perform the same for SCHEDOP_block.
>>
>> Not a functional change.
>>
>> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
>> ---
>> v2:
>>   - For SCHEDOP_block case: export and use vcpu_block_enable_events instead
>
> You need to adjust the commit message for this change, now that you're
> exporting vcpu_block_enable_events().
>
> With that adjusted, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> If there are no other changes needed, you can propose some updated
> wording here and it can be adjusted on commit.
>

Are you ok with

Export vcpu_block_enable_events() to perform the same for SCHEDOP_block.

(in place of "Perform the same for SCHEDOP_block")

?

> ~Andrew

Teddy


Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech