[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH 2/2] xen/arm: irq: drop unreachable pirq callbacks
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Wed, 23 Jul 2025 13:37:25 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofIJmHoaevPsRW5xo9NQu3hu8QjFK49Fm3eu5e7Y8/U=; b=muPDrt4NcYSeEZn1TCGACS4WOwqVfJWa+s7LaSqtRgLlmv4900mJkxVfclUCq1zCnjXNQMT9EdmS16tfrFjDP1jlgN4x3vU3HXJQsB7bmHBvbUbxEBiNQ8uUCLQlZL9bHDuSAj2+uKdG+CnMAEQ1yBYRMR0cNaWAOHR3pjzAXLzgxibMVfWI0BdHrZkWeBDUJpIolmrr+3bAP0mhXVH3+fG+IB17GPxwvtXE74gXN3U8Yfc0Xl2MLG/O/T6o0VlDFuvZZtYMz0JjlaFTbUiLKvsdOfFoP4r2Muw6zmIJMU7bQdHF6V2THmIeuHUUa+y34xdFsJfw80jZNGxTR4LWCQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bLQcqk5UQsoLYl/201PwmkKtwFoAmm9OJNCOMPE0qBBtX0oT5/9aINSna5jNWiz0V3DR/m8opj7IuyNfdqZjqNjWQZBNyxMlG0lB6IH3fL/qkb30BoPLeNAK3P/jX/PXaJcqS0R283+5y01j9vasr5Vf/AgO0isTCX76AaICtjePUOg/K2jDuvMTRaUdp/iU3yDW4Hgzjy7OCN4BPP70KG7IpQB36QPBRmsPGXzifjaesGG/2+ZOoPaTZ4A2wi8aNFjucOtcNVhmNeNR3LjHT3m1D69mUh674/4VtvdNYELfl0IbX9snMv0vfzzFeBkElvjpRG9+QCILD7xiS2w6yw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 23 Jul 2025 10:37:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.25 17:18, Jan Beulich wrote:
On 18.07.2025 13:47, Grygorii Strashko wrote:
On 18.07.25 13:22, Jan Beulich wrote:
On 18.07.2025 12:11, Grygorii Strashko wrote:
From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
Hence all common PIRQ code is under CONFIG_HAS_PIRQ idefs corresponding Arm
arch callbacks become unreachable, so drop them.
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
xen/arch/arm/irq.c | 29 -----------------------------
1 file changed, 29 deletions(-)
Can this really be a separate change? That is, aren't we going to have transient
Misra violations (for Arm only) between the two changes?
The violation exist even before this series, and applies to arm/ppc/riscv
actually
alloc_pirq_struct - unreachable
pirq_guest_bind - unreachable
pirq_guest_unbind - unreachable
pirq_set_affinity - "reachable" at least from compiler point of view.
Would you like to have cumulative, cross-arch change to drop above arch
callbacks and
squash it in previous patch?
If the issue is pre-existing, then it doesn't need squashing and the order
isn't important. But it would indeed be desirable to have the cleanup done
across the board.
I can create clean-up patches for all affected arches.
What's you opinion on how to proceed:
- re-send this series with additional patches
- wait for patch 1 and then send arch specific clean-up series
?
Thank you.
--
Best regards,
-grygorii
|
