[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v8 7/7] xen/sysctl: wrap around sysctl hypercall
- To: Jan Beulich <jbeulich@xxxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Tue, 22 Jul 2025 05:05:59 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahH/iREqET1QswsYPyGgWN49lXPhu6Su9kZrW/lQBQY=; b=IZhyPWN9WExjJvizCiZAdOv0b5fCQkiarkCf6of6jarwJJE48n7Dam7IVpC0YiNWdMdoJ9aZw6Eg3u5jHQqmnih3DTlOMh2HiLGdPQMSqzBrKPF62NxbKufTfba/AH8jGN/8BkyC+4uq/jEYhKDSSH50SYUXwRxj8z6N1WVOOvFoHQkaUx/61e+mpP+YzuJYtxyN5aQqwd9GbZ15msHYyxTML8K9DoYZ/CtvhdZR+Orm/FP+m2dEkpx7wnU3V5nJ5I4w3QG4eZ0Wo4avnOtHeqTSql1HXbQJoboo9bwGaOW0m+ygOHacMsu43+puwSg01Fp3YBrcv12gdA6RxQt+kA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FSk5/nV9Pxydhy86dCvAaaICMlBVZkJg6pE1iUWgy9thfdqRkcyC6KRDzaGnkpufEV6yM8TczHv5NtbRmDGI+1VBqurYTD4y6Ul3tqFDr/mItk6ekCePzX/2TZCSmEO7Fy1OvPsqdgGraoIqhOVhfXCpKcFA8YAGy/P6LlcixgRB+iFWMbiUJvbtye4H7Avmuq6Dq7nbO0KnzZXfedr5lwyFSGS7yt7CN3TZWUbWTcD8QC5ElgzqNchcv27V1woMB0TYiQXmhgy62peFXC9SbKi74qVcjyCXXeNdaq4+/YbuYurx9UxLx2H9JC6KM0Wkg1qOZZ623SGy/SyDXel+2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 22 Jul 2025 05:06:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-07-22T05:05:48.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHb8hzZ4PaGCcXW4ESgBHjQZ1Y4rLQ2DLKAgAebZgA=
- Thread-topic: [PATCH v8 7/7] xen/sysctl: wrap around sysctl hypercall
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, July 17, 2025 4:55 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>; Stabellini, Stefano
> <stefano.stabellini@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger
> Pau Monné <roger.pau@xxxxxxxxxx>; Anthony PERARD
> <anthony.perard@xxxxxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v8 7/7] xen/sysctl: wrap around sysctl hypercall
>
> On 11.07.2025 06:31, Penny Zheng wrote:
> > --- a/xen/common/Makefile
> > +++ b/xen/common/Makefile
> > @@ -49,6 +49,7 @@ obj-y += spinlock.o
> > obj-$(CONFIG_STACK_PROTECTOR) += stack-protector.o obj-y +=
> > stop_machine.o obj-y += symbols.o
> > +obj-$(CONFIG_SYSCTL) += sysctl.o
> > obj-y += tasklet.o
> > obj-y += time.o
> > obj-y += timer.o
> > @@ -70,7 +71,6 @@ obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o
> > memory.o multicall.o xlat.o ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> > obj-y += domctl.o
> > obj-$(CONFIG_VM_EVENT) += monitor.o
> > -obj-y += sysctl.o
> > endif
> >
> > extra-y := symbols-dummy.o
>
> CI demonstrates that this combination of changes is wrong. The job that failed
> (debian-12-x86_64-gcc-ibt) is a randconfig one, and ended up picking both
> SYSCTL=y and PV_SHIM_EXCLUSIVE=y. Which results in sysctl.c being built,
> but domctl.c not being built. Which leaves getdomaininfo() undefined, causing
> linking to fail. In case the next pipeline also ends up failing, I'll simply
> revert that
> change. In case it succeeds, not reverting may be an option, as long as a
> proper fix
> shows up pretty quickly.
>
I've push commit of " xen: move getdomaininfo() to domain.c " to try to fix the
error.
> Jan
|
