[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option
- To: <dmkhn@xxxxxxxxx>, "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 17 Jul 2025 17:43:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=proton.me smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rc2kCiDgncNRc4ziQIBHYWA2aU2frSebKj+SyjZpmOc=; b=qpiKP5S1EMtexVeeob0BuHhwhij36JlJdXYmjYfaxhBgp41IMTMrF7jWGZFtnHE9Fmj6nxdtseIOzIBZI0kedEZqEzpEd04IXAUxEnZoy/kDxyYbwtpVYGKgje47aMskscd88Ymf935iaLHHiSDP8uW60QCy8GbPxTPhL1BwTOYROHG7gFlDmOXLzSmMuvA/Uda0Vkq+jQJisFza+t49EL3n9JM1qhYO3GzSYvqdz211NasXi6B5yeizPtxQolg6bBcdquGvQmdbtSB8I6B2eJlYG6tBp/kCjadthE48kvpYJDwQAc3f3rPS9jQMdm0SB+4/1A2GhPf0AqjjGK63PA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gcFWhLyoDiywxy7eCr86egfxaiOblYB/wkgE8xB/wMpbYJL70CGvjzm9sWPaSfzrJykZSIeqzp+0kefHjCl6aPI5Uy7cFHk6yqT24dKFi57okWFfOlGxITmGhBdaPtzFNQZ8C7qcQHaDfvcP69IgIcQvsBE6YpdSwYsXD3jyw5MWKrP694GYfzu08S0iyYqFl8ue48TvXWOQCXXuX3dgDHhTJdTDTCrGzX1KBCLOApxpr4Ov3NONzzO7O4SS07wQDvRUvn9lK9l52bBCs7p6rPPe6yqX8dRgXggU4GwcJ3TqW+Rw4ioMV6gtGfjJvW3Xn+eo1Phlc333fbQ8I2iY8A==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <anthony.perard@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <julien@xxxxxxx>, <oleksii.kurochko@xxxxxxxxx>, <roger.pau@xxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <dmukhin@xxxxxxxx>, Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 17 Jul 2025 15:43:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Jun 24, 2025 at 9:24 AM CEST, dmkhn wrote:
> On Tue, Jun 24, 2025 at 08:13:08AM +0200, Orzel, Michal wrote:
>>
>>
>> On 24/06/2025 05:55, dmkhn@xxxxxxxxx wrote:
>> > From: Denis Mukhin <dmukhin@xxxxxxxx>
>> >
>> > Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011.
>> Why? We emulate SBSA UART and not PL011. Despite the similarities (the
>> former is
>> a subset of the latter) they are not the same. I find it confusing and
>> drivers
>> for PL011 might not work with SBSA UART. Also, in the future we may want to
>> emulate full PL011 in which case it will be even more confusing.
>
> That's because the emulator is called vpl011, but yes, it is SBSA UART.
> I will adjust to SBSA, thanks!
>
>>
>> Also, why HAS_?
>
> My understanding is that HAS_ is the desired naming convention throughout the
> code (not documented, though), e.g. all Arm UART drivers are gated by HAS_XXX
> (e.g. arch/arm/platforms/Kconfig).
HAS_ is a non-selectable property dependent on the arch. Think HAS_PCI, or
HAS_EHCI, etc. IOW: HAS_X means "you may implement feature X on this arch",
which is why some options have X and HAS_X variants, where X is selectable
while HAS_X is not.
Cheers,
Alejandro
|
