[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/S3: don't lose previously collected CPU data



On Thu, Jul 17, 2025 at 12:14:54PM +0200, Jan Beulich wrote:
> smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume,
> hence it is wrong to overwrite APs' data using boot_cpu_data. With
> 7126b7f806d54 ("x86/CPU: re-work populating of cpu_data[]") this now
> results in a crash, as the cpu_to_socket() use in smp_store_cpu_info()
> then obtains a bad socket number, much like was already observed in [1].
> 
> [1] https://lists.xen.org/archives/html/xen-devel/2025-06/msg01879.html
> 
> Fixes: bb502a8ca5925 ("x86: check feature flags after resume")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.