Re: [PATCH v1 0/9] mm: vm_normal_page*() improvements

[David Hildenbrand <david@xxxxxxxxxx>]

On 17.07.25 00:27, Andrew Morton wrote:
> On Wed, 16 Jul 2025 10:47:29 +0200 David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> > > However the series rejects due to the is_huge_zero_pmd ->
> > > is_huge_zero_pfn changes in Luiz's "mm: introduce snapshot_page() v3"
> > > series, so could we please have a redo against present mm-new?
> > I'm confused: mm-new *still* contains the patch from Luiz series that
> > was originally part of the RFC here.
> >
> > commit 791cb64cd7f8c2314c65d1dd5cb9e05e51c4cd70
> > Author: David Hildenbrand <david@xxxxxxxxxx>
> > Date:   Mon Jul 14 09:16:51 2025 -0400
> >
> >       mm/memory: introduce is_huge_zero_pfn() and use it in vm_normal_page_pmd()
> >
> > If you want to put this series here before Luiz', you'll have to move that
> > single patch as well.
> >
> > But probably this series should be done on top of Luiz work, because Luiz
> > fixes something.
> I'm confused at your confused.  mm-new presently contains Luiz's latest
> v3 series "mm: introduce snapshot_page()" which includes a copy of your
> "mm/memory: introduce is_huge_zero_pfn() and use it in
> vm_normal_page_pmd()".
Let's recap: you said "the series rejects due to the is_huge_zero_pmd ->
is_huge_zero_pfn changes in Luiz's "mm: introduce snapshot_page() v3"
series"

$ git checkout mm/mm-new -b tmp
branch 'tmp' set up to track 'mm/mm-new'.
Switched to a new branch 'tmp'
$ b4 shazam 20250715132350.2448901-1-david@xxxxxxxxxx
Grabbing thread from 
lore.kernel.org/all/20250715132350.2448901-1-david@xxxxxxxxxx/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 17 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 65 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v1 1/9] mm/huge_memory: move more common code into insert_pmd()
  ✓ [PATCH v1 2/9] mm/huge_memory: move more common code into insert_pud()
  ✓ [PATCH v1 3/9] mm/huge_memory: support huge zero folio in 
vmf_insert_folio_pmd()
  ✓ [PATCH v1 4/9] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero 
folio
  ✓ [PATCH v1 5/9] mm/huge_memory: mark PMD mappings of the huge zero folio 
special
  ✓ [PATCH v1 6/9] mm/memory: convert print_bad_pte() to print_bad_page_map()
  ✓ [PATCH v1 7/9] mm/memory: factor out common code from vm_normal_page_*()
    + Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> (✓ DKIM/suse.de)
  ✓ [PATCH v1 8/9] mm: introduce and use vm_normal_page_pud()
    + Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> (✓ DKIM/suse.de)
  ✓ [PATCH v1 9/9] mm: rename vm_ops->find_special_page() to 
vm_ops->find_normal_page()
    + Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> (✓ DKIM/suse.de)
  ---
  ✓ Signed: DKIM/redhat.com
---
Total patches: 9
---
 Base: using specified base-commit 64d19a2cdb7b62bcea83d9309d83e06d7aff4722
Applying: mm/huge_memory: move more common code into insert_pmd()
Applying: mm/huge_memory: move more common code into insert_pud()
Applying: mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()
Applying: fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio
Applying: mm/huge_memory: mark PMD mappings of the huge zero folio special
Applying: mm/memory: convert print_bad_pte() to print_bad_page_map()
Applying: mm/memory: factor out common code from vm_normal_page_*()
Applying: mm: introduce and use vm_normal_page_pud()
Applying: mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page()
$ make mm/memory.o
...
  CC      mm/memory.o

I know that a tree from yesterday temporarily didn't have Luiz patches, so
maybe that's what you ran into.

*anyhow*, I will resend to work around that arm pgdp_get() issue.


--
Cheers,

David / dhildenb