[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
  • Date: Wed, 16 Jul 2025 17:35:03 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jOOgjRjVvWALzMEUCF6yHM2u41pWj/oQq+0JZzCzfG0=; b=IVrjcxPvjHob5fbz9RexHV0jadYDLNLIarYmI5ofqQamjetqDXuR9xcxDNrNcrIAZlVuBTTcOg+M1IcEttANtQeTU7goQLV3ZoZ9ZlpJ2VtLf3c+G5AyDDegHQjaXJd/ZlAr49aAw8PFbLA3I/005MQrmCe4IEasgh9DJynJTB3u+pDzO6gMcC0nITZ7WzZ0lc2CDnYS7safuahI3DOnIdq2TNCoF18vqi2hRQ0JEFpNWvNYmugbB0Byn0fQdZlL8cgcnY4QoZdD/gT0tcciP5iq7fiPR54DyeHEWyUCJmXMdrqJNWHOecl3smVjNn0YqpYP6N6TEL3AOdCvFV7u7g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SNpPw33hOtbk8cLRERNESLMl2UYMk/UB68if9Q5vm/MgTUVDQsl/wMklV/X2asT7TWUAg6DDtObh814Ww0UnOj2b1HawLvUbBr0IfL0QHMHWIVxGyNdB2D25YhLhHUysFKNpt5msMEH8BPYo8djVz+Xxed70Ee5WBsOu7gijP3d6HpEgwUJXYyEVINT1844IIRStp/ggTYzDJAHgzc7/A8HveTj+k/SV2ME4EkZSW7GowMW18RNAjjOA5tn4UUtAcIBcKmTKLscf9tuQXZvmwEF+mN2QmGovPEeZT3kCl4uauw+TTSjE7IWEhtjBaPx89Ip10aT2+YztdHh0zDkR1Q==
  • Cc: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Wed, 16 Jul 2025 15:35:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

llc_colors_str being outside the main loop makes domains without
explicit coloring inherit the colors of the last colored domain parsed.

Move it inside so that's no longer the case.

Fixes: 5948dc16759c("xen/arm: add support for cache coloring...")
Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
---
pipeline: 
https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1930276681
---
 xen/common/device-tree/dom0less-build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/device-tree/dom0less-build.c 
b/xen/common/device-tree/dom0less-build.c
index 221b875a2f..87828d4d9d 100644
--- a/xen/common/device-tree/dom0less-build.c
+++ b/xen/common/device-tree/dom0less-build.c
@@ -829,11 +829,11 @@ void __init create_domUs(void)
     bool iommu = false;
     const struct dt_device_node *cpupool_node,
                                 *chosen = dt_find_node_by_path("/chosen");
-    const char *llc_colors_str = NULL;
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
     {
+        const char *llc_colors_str = NULL;
         struct domain *d;
         struct xen_domctl_createdomain d_cfg = {0};
         unsigned int flags = 0U;

base-commit: dff462313fe0bfa273c54ffc9bff71f054c365af
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.