Re: [PATCH v2 3/3] hvmloader: add new SMBIOS tables (7, 8, 9, 26, 27, 28)

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.07.2025 00:49, Petr Beneš wrote:
> From: Petr Beneš <w1benny@xxxxxxxxx>
> 
> Some SMBIOS tables are used by certain malware families to detect virtualized
> environments via WMI queries.
> 
> To improve stealth for sandboxing purposes, this patch adds support
> for populating these SMBIOS tables from an external binary specified
> via the "smbios_firmware" domain config option:
> 
> * 7 - Cache Info
> * 8 - Port Connector
> * 9 - System Slots
> * 26 - Voltage Probe
> * 27 - Cooling Device
> * 28 - Temperature Probe
> 
> If particular table is absent in binary file, then it will not be mapped to
> memory. This method works for Windows domains as tables 7,8,9,26,27,28 are not
> critical for OS boot and runtime. Also if "smbios_firmware" parameter is not
> provided, these tables will be skipped in write_smbios_tables function.
> 
> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
> Signed-off-by: Anton Belousov <blsvntn@xxxxxxxxxxx>

Once again - who's the original author of this patch? Anton, aiui. Hence his 
S-o-b
wants to be first (chronological order), and he wants to be tagged as the author
of the patch via From:.

The patch itself looks okay to me now. Yet I think we want a SUPPORT.md 
addition,
clarifying that passing in any such overrides is unsupported. After all a guest
can easily be presented bad information this way.

Jan