[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] arm/mpu: Populate a new region in Xen MPU mapping table
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Hari Limaye <Hari.Limaye@xxxxxxx>
- Date: Tue, 15 Jul 2025 08:51:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kU4XT7P5XCMUEYLxr8L9fW9zcVCpf+SOroB2IRxP/O0=; b=LAPESMofY6tohjvI0xAX09c1MzJXprttNthRl71MlsqHtDStWYLJ7WmxBPp/t+qf/wvOXXCgVau47bmQzmuN6YcYEskBnjNAEiP56HEtNmCpLXbKq6eGaapxqSp0czTFxP/Rwre/+vcF/+y2ti8q3WJoA7oiTeQ2UK0UoQaGSCH9uRYrB5iKPGqjzLgh0QL88XySF4BKVZk3fhxHHJWgJkX7KIqKQbjF5PYV2/6QWESg2CGL6FfZya3Wl1lMU/4UZhA2AaG6PhUYOuq0bSLWm+OxXa+TPxNVn1JpOk/9o3t/A5QQRTts2dmu/tAggG6q7g1IkD6KqOjBDsn8rtzZKQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kU4XT7P5XCMUEYLxr8L9fW9zcVCpf+SOroB2IRxP/O0=; b=veYQTDrST7Dd6n1KJtGq/1/hwYHhkP3lF5OXvg46eO0g+f4/qGxL9U0hpLJgxkWcaWqNmyCqisk7gWceFP7G7Ljei4/znk+tBCNa/cZI7mV95TLwAoh+SzjPPWU5dOoWP33KG4u30JhUIZWrdB3m6tCKc32msDMVqhOH57Q2RK8gAenlwin9OZnXCVfhK9YBOQbQqZyA3B09X4zaO5QWyuIZuiElqUKy51h2ky4TMq4Fgf2DXaLsk5SwzZrroiUas60MgfTbI7ZvJYkUoLHqm22LbkF6CdAJOuRxIU/4Q7b9ps7MyH450GojW0Q8zrWvV2/qRH01ehVsxZrbLIWUzg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=WXiRNQAxU2e5Guq6JBouLUhmp+xMvDM7RSyB19YkexIX0aHUj9pe9AfrRJAAOHokYVxB0t/eZ5Ve4beU3ppzFKKnPSGzajO052niulf/EeerVhQvOo3TGagx3H/hbHAcEPeeqRhQdC+ObiO+8h/TW/agLnv5+qd64Qi4oKQYkQVf39CEtbiOdQRwzOD6ivvdqV0j1shLZYRr03il58+tURi/VgR7BP2SntZDzqNHAD6tUA6LvaW6mA5oeZsL/jTa7Uq4fJjVKCmsCKvZWkiyytjZPWjcvM4NPN/RYrXfW99hdcuPSAPeHCDbtok0vRc6STop6QpqsE96W6pdVdfubA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a/eDzPT7sUM14tb75qL09pQvNNNcfc0SVwt6PLWaQ3wwVyMNR7J89gqSPc5kVyB0q/4v+ZAoEQ9adIMxbYpD/0lFULjNVBrDJby6rfwMy6oJnyU8XeM9JDxaupFW5IsQuN9yoe/wkkjmrkr5633xesCugfYBloaAeRYh8wdXu2Omou/SkrNCIhcj/Oa3rfHBFWE9DeyDCoq2jfUEmFYrYMQKP6tR1HEWHYKzyTKR8RUyNxG2+dOOMTn1OXzt5KEPW7c/FFpux1SHJFCMQoDjz4uOt9DYncVSTpH2jBd5TxVRzOmtRyeZwI24zxqdKOvKPsTLebx083bqmF7X6rNEbg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Tue, 15 Jul 2025 08:51:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb9WFmk+pEurGWy0mD0bzjRIyBMbQy4FyA
- Thread-topic: [PATCH v3 3/6] arm/mpu: Populate a new region in Xen MPU mapping table
Hi Michal.
>> + if ( base >= limit )
> Given that limit is exclusive, to prevent empty regions, you would need to
> check
> for base >= (limit - 1), even though it's not really possible because today we
> require page aligned addresses (limit must be at least bigger or equal than
> base
> + PAGE_SIZE). That said, it can change one day, so I would suggest to modify
> the
> check. With that:
>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
>
I think that this one is maybe also fine as-is?
Cheers,
Hari
|
