Re: [PATCH v2] xen/efi: Do not undefine not defined macro

[Frediano Ziglio <frediano.ziglio@xxxxxxxxx>]

On Tue, Jun 24, 2025 at 12:57 PM Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 24/06/2025 12:45 pm, Frediano Ziglio wrote:
> > The "buffer" macro is not defined.
> >
> > Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>
> > Acked-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>
> While correct, the grammar isn't great.  I'd suggest "Drop stale #undef
> buffer" for the subject, and "The "buffer" macro was removed when
> keyhandler_scratch was removed."
>

Fine for me.
Not sure about the acknowledgement.

> Can fix on commit.
>
> ~Andrew

Frediano