Re: [PATCH v4] xen/char: implement suspend/resume calls for SCIF driver

[Mykola Kvach <xakep.amatop@xxxxxxxxx>]

Hi Jan,

On Tue, Jun 24, 2025 at 10:53 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 24.06.2025 09:18, Mykola Kvach wrote:
> > @@ -281,6 +313,10 @@ static struct uart_driver __read_mostly 
> > scif_uart_driver = {
> >      .start_tx     = scif_uart_start_tx,
> >      .stop_tx      = scif_uart_stop_tx,
> >      .vuart_info   = scif_vuart_info,
> > +#ifdef CONFIG_SYSTEM_SUSPEND
> > +    .suspend      = scif_uart_suspend,
> > +    .resume       = scif_uart_resume,
> > +#endif
> >  };
>
> As this being put inside #ifdef was to be expected, imo a prereq change is to
> also make the struct fields conditional in xen/console.h. I think I did even
> comment to this effect back at the time.

Would you prefer that I include this change in the current patch
series, or is it acceptable to address it in a separate patch?

>
> Jan

Best Regards,
Mykola