[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Thu, 19 Jun 2025 06:14:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o2r8Na2cNk1ynXA/naaI2cd0FLTjugwUwwl2Dhl4eFI=; b=gdPYGzvti1vMg5vp85GxrRx19sJKMtNQtQQHGC3waiXKPka80GdiSFa2s+uMoYSXNFJFNjqhnFR9u9GF/NkPeLIPvMJ1GApBmAyRwFDlXVmfaua/UdxDhLtIog40lQqfsQz110EbfrS/lIJXMFszqQCEll/7gGmIRWMY5TchtlMjtJqnOMgbePq25FqzwkFlIYIgEbpJ2aU5qLgWM5auqK06kQIjvl/EYt+MrGGtqYtMvulalMXReAp9FOh9jPYMVd2lOfdxv7CcZtsUSiAGATkeWyxVuQYOIomqCtqExc+EP5X0iRXGDISXS381Dai45RW49TWZ+SlAVQ7VzRPC+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mihsqB1vWk+3wZE44ya0EpSyCUSMgevBhg9CluASWPg8YrRp4ZhUT79Hz1Oyql3jAQJ46rwxzORFaj8l7eEb3co42hCN+8jJl7bcW3tA5S6L1Au+0jxX4vetL1dqKTg9jCiOOngD8DNsj2L2bunRpAkw/HCWCauEFbVy6y5iRX8GzQw4ZEwyH6zj6zEQi5N768WK9ZuQipdJqHG1lsAVdxIMioS6rWfXYo6JqEPci7ZpuEdktPxuIJCEM4KQCWDv5poe2uSObMy3euANuwRXhbBF4JfBXsSpUcyrkMXzgpR4k30qc/DNpxVdaJk/9qHOc1QxGBC2iA/3QZm4r4mSxQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Thu, 19 Jun 2025 06:15:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHb23yakGdVC9XxvEWnYcnp8zrTt7QJBRKAgAGLVIA=
- Thread-topic: [PATCH v6 2/8] vpci: Refactor REGISTER_VPCI_INIT
On 2025/6/18 22:33, Jan Beulich wrote:
> On 12.06.2025 11:29, Jiqian Chen wrote:
>> --- a/xen/include/xen/vpci.h
>> +++ b/xen/include/xen/vpci.h
>> @@ -13,11 +13,12 @@ typedef uint32_t vpci_read_t(const struct pci_dev *pdev,
>> unsigned int reg,
>> typedef void vpci_write_t(const struct pci_dev *pdev, unsigned int reg,
>> uint32_t val, void *data);
>>
>> -typedef int vpci_register_init_t(struct pci_dev *dev);
>> -
>> -#define VPCI_PRIORITY_HIGH "1"
>> -#define VPCI_PRIORITY_MIDDLE "5"
>> -#define VPCI_PRIORITY_LOW "9"
>> +typedef struct {
>> + unsigned int id;
>> + bool is_ext;
>> + int (*init)(struct pci_dev *pdev);
>> + int (*cleanup)(struct pci_dev *pdev);
>
> Is const really not possible to add to at least one of these two?
Will change to be :
typedef struct {
unsigned int id;
bool is_ext;
int (* const init)(struct pci_dev *pdev);
int (* const cleanup)(struct pci_dev *pdev);
} vpci_capability_t;
>
>> +} vpci_capability_t;
>
> As you have it here, ...
>
>> @@ -29,9 +30,22 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
>> */
>> #define VPCI_MAX_VIRT_DEV (PCI_SLOT(~0) + 1)
>>
>> -#define REGISTER_VPCI_INIT(x, p) \
>> - static vpci_register_init_t *const x##_entry \
>> - __used_section(".data.vpci." p) = (x)
>> +#define REGISTER_VPCI_CAPABILITY(cap, finit, fclean, ext) \
>> + static const vpci_capability_t finit##_t = { \
>
> ... _t suffixes generally designate types. I don't think we should abuse
> that suffix for an identifier of a variable.
What do you think I should change to?
>
> Jan
--
Best regards,
Jiqian Chen.
|
