Re: [PATCH v3 07/14] x86: Replace arch-specific boot_domain common one bootdomain

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
> Add the single arch-specific field in an "arch" subfield defined in
> asm/bootfdt.h.
> 
> No functional change intended.
> 
> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>
> ---
> v3:
>   * Avoid the bootdomain/boot_domain renames.
> ---
>  xen/arch/x86/include/asm/boot-domain.h | 33 --------------------------
>  xen/arch/x86/include/asm/bootfdt.h     |  6 +++++
>  xen/arch/x86/include/asm/bootinfo.h    |  1 -
>  xen/arch/x86/setup.c                   | 12 ++++++----
>  xen/include/xen/bootfdt.h              |  4 ++++
>  5 files changed, 17 insertions(+), 39 deletions(-)
>  delete mode 100644 xen/arch/x86/include/asm/boot-domain.h
> 
> diff --git a/xen/arch/x86/include/asm/boot-domain.h 
> b/xen/arch/x86/include/asm/boot-domain.h
> deleted file mode 100644
> index d7c6042e25..0000000000
> --- a/xen/arch/x86/include/asm/boot-domain.h
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * Copyright (c) 2024 Apertus Solutions, LLC
> - * Author: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> - * Copyright (c) 2024 Christopher Clark <christopher.w.clark@xxxxxxxxx>
> - */
> -
> -#ifndef __XEN_X86_BOOTDOMAIN_H__
> -#define __XEN_X86_BOOTDOMAIN_H__
> -
> -#include <public/xen.h>
> -
> -struct boot_domain {
> -    domid_t domid;
> -
> -    struct boot_module *kernel;
> -    struct boot_module *module;
> -    const char *cmdline;
> -
> -    struct domain *d;
> -};
> -
> -#endif
> -
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * tab-width: 4
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/arch/x86/include/asm/bootfdt.h 
> b/xen/arch/x86/include/asm/bootfdt.h
> index a4c4bf30b9..c21dbe961b 100644
> --- a/xen/arch/x86/include/asm/bootfdt.h
> +++ b/xen/arch/x86/include/asm/bootfdt.h
> @@ -3,6 +3,12 @@
>  #define X86_BOOTFDT_H
>  
>  #include <xen/types.h>
> +#include <public/xen.h>
> +
> +struct arch_boot_domain
> +{
> +    domid_t domid;
> +};

With the understanding from your previous reply that it is best not to
use d->domain_id:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


>  struct arch_boot_module
>  {