Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote:
> The migration stream is a stable ABI.  What this does is break the ability to
> inspection and operate on pre-Xen-4.21 streams.

Do you mean Xen 4.21 should be able to accept migration of a domU with
qemu trad? I don't think it's a desirable feature...

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> ---
>  tools/python/xen/migration/libxl.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/python/xen/migration/libxl.py 
> b/tools/python/xen/migration/libxl.py
> index dc5c7ac3550c..5dcb50fe0207 100644
> --- a/tools/python/xen/migration/libxl.py
> +++ b/tools/python/xen/migration/libxl.py
> @@ -51,10 +51,12 @@ rec_type_to_str = {
>  EMULATOR_HEADER_FORMAT = "II"
>  
>  EMULATOR_ID_unknown       = 0x00000000
> +EMULATOR_ID_qemu_trad     = 0x00000001
>  EMULATOR_ID_qemu_upstream = 0x00000002
>  
>  emulator_id_to_str = {
>      EMULATOR_ID_unknown       : "Unknown",
> +    EMULATOR_ID_qemu_trad     : "Qemu Traditional",
>      EMULATOR_ID_qemu_upstream : "Qemu Upstream",
>  }
>  
> 
> base-commit: 286c4cc267005f73aba831d22d65abe6874ceaea
> -- 
> 2.39.5
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature