[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 11/15] xen/x86: implement EPP support for the amd-cppc driver in active mode
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Fri, 9 May 2025 03:14:17 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2r/yog852ogEyjKEGCoySg2Zspyw8WgHf0Xvi/lWea8=; b=QnrbKuLsicYycuCebpWaGNPmZjohV2uoUwLqRk09ItK49udruBebKvh08oGMMXc2KNjjDQDQVgaR9aREIllkMqXeJQBjpETEdhd7nr/bxTnFFAntjvQWgU28oxOgqLpgrl81qXJdfqOJVarJ3r0xZAw56+bMQ9knllcx/vIxRxuqBvGP03jUNPdV6BVe/Eckld8muHPhSDvi/muSmNT1iuoOoBfYRu6NMPMqKTGUlhe3936wNlck9Nvzi4JvdlyRDw71PpNqKfaVrOb67iOVAp930cUBE8Bf8xhiHpxOoIP3MsI3HZtHQ2y/nTMbThYkO1v1Q+dmi5UXNgSVyt8g/g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HIBuRKbNgnchziu9arHKtbMBcvRg+LSHv2bHXMjLiRvDLc2AncvaAy8OhvCVuDgdA4bgyG7L2UjIbEeq5wtCQb6q3E2xe0mMX+TMm7raS39CbyYpMoDpwh7Qjt9fiMbYq0dnHTfFnxOOH2G3/eTFGx5ZXHS4YSPgfGlG908kowhLZzPm+BsLIIBAXdFLd0Xg8Lcfdy/h2s+KNSBlNhF7+FsPNT32BLJF7d3dyB+eF2oBrLVkGeAKYI22GgaaE9SYDJguKvR2G/Fz5hIB/pYiDs2RASsww03w+KDWKmUcKN//k9JWg50UnqsQbzAf0hC9HbKMSDFCxjM3onJmtfy6sA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 09 May 2025 03:14:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_ActionId=e4682b6a-0079-47aa-899c-5b67ef962cba;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_ContentBits=0;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_Enabled=true;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_Method=Privileged;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_Name=Published AMD Product;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_SetDate=2025-05-09T03:14:07Z;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_0fec2151-cbe0-4586-8a3f-997880a38a28_Tag=10, 0, 1, 1;
- Thread-index: AQHbrRCuGuHP44zrR0KG5VY9cm/pkLO68EcAgA7Q8sA=
- Thread-topic: [PATCH v4 11/15] xen/x86: implement EPP support for the amd-cppc driver in active mode
[Public]
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, April 30, 2025 12:39 AM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Roger
> Pau Monné <roger.pau@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 11/15] xen/x86: implement EPP support for the amd-cppc
> driver in active mode
>
> On 14.04.2025 09:40, Penny Zheng wrote:
> > @@ -434,12 +464,82 @@ static int cf_check
> > amd_cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
> >
> > amd_cppc_boost_init(policy, data);
> >
> > + return 0;
> > +}
> > +
> > +static int cf_check amd_cppc_cpufreq_cpu_init(struct cpufreq_policy
> > +*policy) {
> > + int ret;
> > +
> > + ret = amd_cppc_cpufreq_init_perf(policy);
> > + if ( ret )
> > + return ret;
> > +
> > amd_cppc_verbose(policy->cpu,
> > "CPU initialized with amd-cppc passive mode\n");
> >
> > return 0;
> > }
> >
> > +static int cf_check amd_cppc_epp_cpu_init(struct cpufreq_policy
> > +*policy) {
> > + int ret;
> > +
> > + ret = amd_cppc_cpufreq_init_perf(policy);
> > + if ( ret )
> > + return ret;
> > +
> > + policy->policy = cpufreq_policy_from_governor(policy->governor);
>
> This is the init part, which is fine. What if the governor is being changed,
> though?
> The struct field is new, and there's no other place I can spot where it would
> be
> adjusted.
>
Yes, I've missed the part that user changing governor through "xenpm
set-scaling-governor"
I'll add a new commit to fix
>
> Jan
|
