[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 5/7] arm/mpu: Introduce utility functions for the pr_t type
- To: "Orzel, Michal" <Michal.Orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 6 May 2025 08:45:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZvUJUrNl6ANajshaEcEYREoNVnfY8bz+KZSy/ybfWM4=; b=uYf+uRsIohZ7cqGvb/Ol9bdDj7GthQAJizJunHQa4bm8RsA6YMnRktPUpdkwp+c9tTc90GnGymiK6vUDzeaX7DzrryM3m5nZtZLpopTMzywABcd8MreMWGvFVvkf88aY3MDbIZmepbFcaAtx+HWVROE2oMKzkUVrsc9aAHICfmI/9WKl5r7d/++A5w0q8G6TRm6FhpOYW7osv6jOa5CbvoIt51NAJkq0opZFmqj0Ny36BtkAmrHhmQ7/7ejfCiMOk5NMtrdpK1wQ4UNiq+1qKUBGrj65UkfACnAmQNOvHid+OJUGBcqGvjB/aNy7ezGXSnrENTghPKbTkVPxUvX4cA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZvUJUrNl6ANajshaEcEYREoNVnfY8bz+KZSy/ybfWM4=; b=UL3DOQPYi5K8Z6PEX1xUCL4lv6RtOAPYcXf72IZBPPFHFZRL/sQtG4/WdTWmKUaC+Q5YkePzyUwiEUSdEhhRai9sTl7mB4VSrf5yviV1eTghU2YyaPXCuolIgD1FblTToSNLmv6er1C+nnST979fLW0oIgi72aiViRBuJ9VytT6mELVK+WIpJZJfbG33NOR/izlLsdI38rBAUpAqjQsLpNY7aihBJOA/95XqZpPChHF2wIieo1n3ceCZlAGSkNQbjLYx9yyo7zlduQHsvrtLJXemriY+xBw1EvKxJgkHaYLHQazOdstaY24OQJrGbPB0P0Fxk2Wc+QSVSq5gEn0SVw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=w+3jHi2Lhe4DLm8uI/cJuOJLsQQLwMe/BhUvgdOz6l1XfSOWCJaN2jaXue1p8jPGCrshcQbGXY2HiZQjAaLWiW+Hhon+NYln+t36AKInmRYHLmVaMXRpRcMCyIJJ1FzXHQF51u3PE9tMJCvrhhxxbfonDFXtIB7ai/YkyTm2A3vbHQb2N92pss2Ml1wXafOoAHt6RIu0TJ95iW5LzqxHlRpEZlWIT7YhuTsLmEckiZvtO7LkFhWStpEStOtIsvHsDxPKorOUIF8KB/w+Oe5CY5HmEC88JXoMQhfAMiaHEIpo5+QlK7iah8cyC2gwnFcmREyv+6ly9JPfn8a5yjTACw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jh6L38isQPgmjrLXEBymkwVUZ3OTZYkCpSXPEU+qtd71TYNO72CK16y05H7aHlRcH+Oh/NabNBsneYK/eiTcL/7Q3w9pSvEr8cVeeApbCxixUMa7diElcG/OPkek6a5+9Tj+Y6D53laMj+h+RxJf+A1UOsQo5rRxUlKciCsEDEDAENfKbW59R0VmSeOjiOlj8qeUp7kGLJzbMbP6HX8XCTQvzJtDFZC2NodJWHQ4fPmGXhyiqcps2qwCKwu6OjunA7SMF98bq+wnV7WpvpePT6YllFS4nyBirXP31K39Lc8huc7qK/HGDp8B6EdjX2Q/lZP8VrQ3SWZFzDYSdIqj0Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 06 May 2025 08:46:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbuRpkN0hqV8eyHEGiv1K+YR6eKbPD+ocAgAFZpwA=
- Thread-topic: [PATCH v4 5/7] arm/mpu: Introduce utility functions for the pr_t type
Hi Michal,
> On 5 May 2025, at 13:08, Orzel, Michal <Michal.Orzel@xxxxxxx> wrote:
>
>
>
> On 29/04/2025 17:20, Luca Fancellu wrote:
>> Introduce few utility function to manipulate and handle the
> s/few/a few/
> s/function/functions/
Ok
>>
>> diff --git a/xen/arch/arm/include/asm/mpu.h b/xen/arch/arm/include/asm/mpu.h
>> index 40a86140b6cc..0e0a7f05ade9 100644
>> --- a/xen/arch/arm/include/asm/mpu.h
>> +++ b/xen/arch/arm/include/asm/mpu.h
>> @@ -24,6 +24,70 @@
>> #define NUM_MPU_REGIONS_MASK (NUM_MPU_REGIONS - 1)
>> #define MAX_MPU_REGION_NR 255
>>
>> +#ifndef __ASSEMBLY__
>> +
>> +#ifdef CONFIG_ARM_64
>> +/*
>> + * Set base address of MPU protection region.
>> + *
>> + * @pr: pointer to the protection region structure.
>> + * @base: base address as base of the protection region.
>> + */
>> +static inline void pr_set_base(pr_t *pr, paddr_t base)
>> +{
>> + pr->prbar.reg.base = (base >> MPU_REGION_SHIFT);
> Shouldn't you take MPU_REGION_RES0 into account?
Yes indeed, I’ll fix
Cheers,
Luca
|
