[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 01/15] xen/cpufreq: move "init" flag into common structure
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Tue, 6 May 2025 05:33:16 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NgH5atrwI9S1LyAVIiw6U2HammoJaq3frSdF73xa3DI=; b=eXe0YDunfu5CF2JTiQ0r68ZyORktqKV426FhlXZD0PasxpzU/bz4kw4U4w3ZLzdJ4EdY4JOrUJvBNIs/eqv6FFYXCvoHzedNO24hGt4HXiAm1Y/r5Gp0f22GK+eTSNvByTtEXkjtRQF7HVkucvUsT3Rl7zZYPfpUqj3muPVb4ShU6MZ/XTWj+8h2Be11v3uVn1uyqYPzDJ/xovvXe1R3PCp+gwY8pD/LteqqsiNMxxReTZ/E6IQwwDLX2oR/3ynv+tADOUBSvOD/9eTGF+fg15ufKseRw7YOT3hT4OWSWr+P+0FpcbJt0GYgFvaHAsa6Qttx4cyTUCxmy/Vd70DoaQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UqKSXRaXu32Bt3HpfWv6tRroQcGtheHlxPcrbwyhSZ66K94pzsYg/5vE/45I5Z2l9RWP5lklK+eWf6+khmLU/Oc8MLAELdRCjcvNJwC8VDiBwmPpJoc9fxcn+g3vv27GR3bhlW7VNwyMwVsmp5q0WeuPFnX31l2fBHqxw25zTupFzwr5PIrlzrpTz0EXEAbCg9wVMxJ8m30NUSK8Ewq2FUrJP+/FYZhubD2/oK21B1aBopluJrznsvWtd6Efo47W24lWsrBGJzkGUbSVg/bDRb0dj7BGBxtVYVLR7HtnYyN8/HIB9XcyfMzpD5SPwdqiQjvou3pFq4wtWc1mZVaoww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 May 2025 05:33:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ActionId=53968fb7-d563-4c53-bc82-a3b08ce75bf2;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=0;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=true;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-05-06T05:32:58Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Tag=10, 0, 1, 1;
- Thread-index: AQHbrRCfHxxYxeWsPkK2Iot0Lv1PhrOn/B0AgB05whA=
- Thread-topic: [PATCH v4 01/15] xen/cpufreq: move "init" flag into common structure
[Public]
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, April 17, 2025 11:12 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 01/15] xen/cpufreq: move "init" flag into common
> structure
>
> On 14.04.2025 09:40, Penny Zheng wrote:
> > AMD cpufreq cores will be intialized in two modes, legacy P-state
> > mode, and CPPC mode. So "init" flag shall be extracted from specific
> > "struct xen_processor_perf", and placed in the common "struct
> > processor_pminfo".
>
> The code change is certainly acceptable, as being largely mechanical.
> However, the above doesn't explain _why_ we need that change. There's
> probably a little more connection that needs making between that's there and
> what
> you mean to add.
>
How about complement the following description:
```
Otherwise, later when introducing new sub-hypercall
to propagate CPPC data in commit "xen/x86: introduce new sub-hypercall to
propagate CPPC data", we need to pass irrelevant px-specific
"struct xen_processor_perf" in set_cppc_pminfo() to just set init flag.
```
> Jan
|
