Re: [PATCH v3 4/8] arm/static-shmem.h: drop inclusion of asm/setup.h

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 2 May 2025, Oleksii Kurochko wrote:
> Nothing is dependent from asm/setup.h in asm/static-shmem.h so inclusion of
> asm/setup.h is droped.

Actually, this patch is not currently dropping any inclusions


> After this drop the following compilation error related to impicit declaration
> of the following functions device_tree_get_reg and map_device_irqs_to_domain,
> device_tree_get_u32 occur during compilation of dom0less-build.c ( as they are
> declared in asm/setup.h ).
> 
> Add inclusion of <asm/setup.h> in dt-overlay.c as it is using handle_device()
> declared in <asm/setup.h>.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V2-3:
>  - Nothing changed. Only rebase.
> ---
>  xen/arch/arm/dom0less-build.c       | 1 +
>  xen/common/device-tree/dt-overlay.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c
> index c0634dd61e..7eecd06d44 100644
> --- a/xen/arch/arm/dom0less-build.c
> +++ b/xen/arch/arm/dom0less-build.c
> @@ -20,6 +20,7 @@
>  #include <asm/dom0less-build.h>
>  #include <asm/domain_build.h>
>  #include <asm/grant_table.h>
> +#include <asm/setup.h>
>  #include <asm/static-memory.h>
>  #include <asm/static-shmem.h>
>  
> diff --git a/xen/common/device-tree/dt-overlay.c 
> b/xen/common/device-tree/dt-overlay.c
> index 81107cb48d..d184186c01 100644
> --- a/xen/common/device-tree/dt-overlay.c
> +++ b/xen/common/device-tree/dt-overlay.c
> @@ -13,6 +13,8 @@
>  #include <xen/libfdt/libfdt.h>
>  #include <xen/xmalloc.h>
>  
> +#include <asm/setup.h>
> +
>  #define DT_OVERLAY_MAX_SIZE KB(500)
>  
>  static LIST_HEAD(overlay_tracker);
> -- 
> 2.49.0
>