[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[XEN PATCH v2 1/3] xen/arm: platform: address violation of MISRA C Rule 7.2
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Tue, 25 Feb 2025 10:38:22 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1740476310; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=NaFM1ueXPHGKYX1U4ZSt2Db8MZfE259Ddc2DPa/4Sw4=; b=zT6IoJmiGL0WofYBpGe5gIVyHZBRR+ukecXu6olx1MlwOlc2f8MTTcHoUHoj3idQSPv+ TWOE/QAncA5kRKNq3NhYGMNuPhQg3dKRzmhrx6o53Kvgak58zg9blZrkGpeGH1CuY1i/H BkCAipNolktmKYnjY/O8mc5ylBAqALprWAQcADUYDRYQIBEG78ejpOWmyZiBslMNsQOoO 1RkVlzo6uydXMRTjkFR0BmplCHMkQDphT8JexcE4vUV5mlBhWaH0sbai0leZFVom5MXWo /dTYPgCl5lgHFUPxUQUcTvMFdrWp+I2oqOIgkF+ZoGiAVfXJgp6pJEkMPCdUWz0bAHJ/Y tzn/zs/n8SgXcqnqZ1pNCs8KKr7KLXLsxxhhKL7OFzLTxP1jvhTFwkjKYOmw6ESVaNnuv rO16qztLLlxG2Nfkj3yarEdoaKEAQvjptHEbgpbCqaqvqwfMi4t3U4H1+yuQ3yUmN289u zQuDd7e3XcKLGAmSIm3x2owqnOoYVKd1TABZrz0Z899KL01N6Jq1TATPP0AbVfHq7P3eR dO4FzLqA5FHY5OkOr1SUdqlpejjv3Uhov//Hja+idu+Y+OHp6oifROxfmBvxAJuCoqJEx nIGZHyYUoN54VnJ/FLtLLClEUmAE2UjkFUkNsPAOO6arCe8uBhPzPIHH9q8W9jU=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1740476310; b=UgHK9SUHjxkog9+ljIoXBvg075L4hczi7boVL00JrO2Rcnz+8wXYhtusuJVxhS9EZqqU AnTagonxtRM9w9KVv9+SMVQdiyBrYZTndUgcof36r0gALeQJwstnYR4i+tmJtZOkQNuVv UmyZsyOJJD9ozeqBNcmRprs/pXMWlAtr2lkcK4NpDzyTrIJzVp5EjE3iTLnFY3iHNjQ+o Y2ExdOZ3h8Ca87NtAiylOaOLfUNBchb/PxivkyTYsVDzTeguH6/K0s16ZKfrRUdOFL5sY Lmx+xPeikSiGJ+bDVYgjLLuFoxgyDU1XCvMrY1eoGdhvLZVoIhmPiZk0ZaPaMlK+sAlkD AXcIQaPP4iGtxOb5ORBjkylesy0Ht6Ra/lU/X6WgLz7sykztZgrA1cGkgLNPGLQkVUgk6 VnMS747js7s8jllWH4aIJFadzwFgSOuDwJAf9K0ezBfjQHz49tsPFDQKkj0D8HNZaFNMw BMLAUVDl5z0S48KZtvw/9ZxwjMMb2j8ufUY6coLI9ilgw80HS2YJwpWRO+AXD6A13WYQS 9f0nkKPx68/JwqG9AIyklx8KbbF+nJmB2qasijowXBOmqMpjaDlXeq8uTmmBBEBKRx4TU tLk9l/aMWuPdH4Fpa1HrXk5CPjEhKHuY9BnPDg1yjVOGqcCWrHrvVQ5ig2VSbhM=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 25 Feb 2025 09:38:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Rule 7.2 states: "A u or U suffix shall be applied to all integer
constants that are represented in an unsigned type".
Some PM_* constants are unsigned quantities, despite some
of them being representable in a signed type, so a 'U' suffix
should be present.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
This fix is needed in order to keep the rule clean when the
Xen configuration under static analysis is changed later in patch 3
of this series.
Only PM_RSTC_WRCFG_CLR is strictly needed to conform to the rule,
but the other constants have a 'U' added for consistency. PM_RSTC
and PM_WDOG are used as offsets, so in principle they can be negative,
therefore they are left as is.
---
xen/arch/arm/platforms/brcm-raspberry-pi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c
b/xen/arch/arm/platforms/brcm-raspberry-pi.c
index 407ec07f63b8..d49460329cc8 100644
--- a/xen/arch/arm/platforms/brcm-raspberry-pi.c
+++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c
@@ -47,11 +47,11 @@ static const struct dt_device_match rpi4_blacklist_dev[]
__initconst =
};
-#define PM_PASSWORD 0x5a000000
+#define PM_PASSWORD 0x5a000000U
#define PM_RSTC 0x1c
#define PM_WDOG 0x24
-#define PM_RSTC_WRCFG_FULL_RESET 0x00000020
-#define PM_RSTC_WRCFG_CLR 0xffffffcf
+#define PM_RSTC_WRCFG_FULL_RESET 0x00000020U
+#define PM_RSTC_WRCFG_CLR 0xffffffcfU
static void __iomem *rpi4_map_watchdog(void)
{
--
2.43.0
|
