[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG?] Wrong RC reported during 'make install'


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 19 Feb 2025 18:10:16 +0000
  • Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, committers@xxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • Delivery-date: Wed, 19 Feb 2025 18:10:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/02/2025 7:15 am, Jan Beulich wrote:
> On 13.02.2025 20:09, Stefano Stabellini wrote:
>> On Thu, 13 Feb 2025, Jan Beulich wrote:
>>> On 13.02.2025 01:51, Andrew Cooper wrote:
>>>> On 12/02/2025 9:52 pm, Stefano Stabellini wrote:
>>>>> On Wed, 12 Feb 2025, Oleksii Kurochko wrote:
>>>>>> Hello everyone,
>>>>>>
>>>>>> During the installation of Xen on an ARM server machine from the source 
>>>>>> code,
>>>>>> I found that the wrong release candidate (rc) is being used:
>>>>>>   $ make install  
>>>>>>     install -m0644 -p xen //boot/xen-4.20-rc  
>>>>>>     install: cannot remove ‘//boot/xen-4.20-rc’: Permission denied  
>>>>>>     make[1]: *** [Makefile:507: _install] Error 1
>>>>>> My expectation is that it should be xen-4.20-rc4.
>>>>>>
>>>>>> I'm not sure if this behavior is intentional or if users are expected to 
>>>>>> set
>>>>>> the XEN_VENDORVERSION variable manually to ensure the correct release
>>>>>> candidate number.
>>>>>>
>>>>>> In my opinion, we should set the proper release candidate number after
>>>>>> "xen-4.20-rc" automatically.
>>>>>>
>>>>>> Does anyone have any thoughts or suggestions on how to resolve this 
>>>>>> issue?
>>>>> Hi Oleksii,
>>>>>
>>>>> I did a quick test and I see exactly the same on x86 as well. This patch
>>>>> fixes it, but then it would need someone to update the RC number in
>>>>> xen/Makefile every time a new RC is made.
>>>>>
>>>>> ---
>>>>> xen: add RC version number to xen filename
>>>>>
>>>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>>>> This is a direct consequence of the request to keep XEN_EXTRAVERSION at
>>>> "-rc" throughout the release cycle.
>>>>
>>>> I'm having to manually edit that simply to create the tarballs
>>>> correctly, which in turn means that the tarball isn't a byte-for-byte
>>>> identical `git archive` of the tag it purports to be.
>>> Just for my understanding - may I ask why this editing is necessary?
>>> Other release technicians never mentioned the (indeed undesirable)
>>> need to do so.
>> This is not an answer to Jan's question, more me highlighting
>> priorities.
>>
>> While having the appropriate RC version in the Xen name during the RC
>> phase of the release process would be nice, I do not believe it is
>> mandatory. We do need it in the official release tarballs though.

Release tarballs are fine, because they are always tagged on a commit
editing the micro version in XEN_EXTRAVERSION.

It's only RC tarballs that go wrong.

>>
>> So the most important consideration for me is making the release
>> technician's job easier and less error-prone. Therefore, I believe we
>> should follow Andrew and Julien's recommendation on this.
>>
>> Andrew, just to be clear, are you recommending to go with a patch
>> similar to the one I posted, and then update the XEN_VENDORVERSION
>> with a new commit every time there is a new RC? Or are you suggesting
>> something else? I wasn't certain reading your reply.
> Just one point here: I don't think we ought to be playing with
> XEN_VENDORVERSION. If we switch, we ought to switch back to how it
> was long ago - the RC number being part of XEN_EXTRAVERSION.
> XEN_VENDORVERSION really should be left to vendors.

Hopefully the other email is clear and covers everything, but tl;dr, I
suggest we do edit XEN_EXTRAVERSION (and not XEN_VENDORVERSION) for each
RC tarball.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.