[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/MCE-telem: adjust cookie definition
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 19 Feb 2025 12:04:23 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1739963063; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=oRZPL/o4+YSCKebokHyGIh/wEdUND57l0X2XUl83GFA=; b=K4lNJYGPbxMqrD3CGcMyDHtAoxRXTfMVAdxkyveiJqrVrrnne0DScOAvu1/qXhbJ8o0a J+v/Kc4YBerEDkBf8O4NStZkjD/pGsMA6cUx+AOj5WNtl5El6aYSkANf6tofS6Mt7t9GK 9+/BnSjoBEdbL8qSs2TlSZURTSlG1pYrpRql1xnWIup4V+bfhGIfSt71zGG678GgajSne fBStDNOuSG6GgiqEMHsroXr0VHv8C3kWC0JQk+dpIo/tEoHq4MmI4DXmVTF5TGs7qFJJi /LbzJZn+rMAodiZzIfIHTfNIj93rGHTRKNNl39zNTfLNaGsg8v90p/f4NfSYHAo41mQ+7 ZsmDY/BUEBibpNOxuP0HPOuqwB1PCy6SAXLLaoKauE/46QfBqxREeLxtQL2lfqALknFPv dmRNAt1wKDpMi2bOiZuDW8CMS3yM58SCSqVNcCQhDTGo6mUBqxXCJT/uud+q9s0W5C56u NYqf29T4kWIARCZhnvWjQEEHq+tBj2zPckv0vcr8zve4SjS8LEygkDxxWfXcyyxUPOZ75 wgbx4NqE4A/6R2KPOqL7JOOYiygXfIX96OUpkoyCULs66eDi/upmnGNdebS9xsECS+yH3 Mwlf4jCSE14+waL4xiI6IcimQwXGo0esAIDvxpOpmd8xQBmQn6u7dJGA55J2KN4=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739963063; b=VjN77YJ121ptfMuifkpgmDw2lzZEN19D2/vL2+tg4dwfpryWF82PpeIyh2Vr7Btdhsiu EoIE2fg2jQP35sSqyKMMJdBmjRoVjWZI6g9WWvAOBCo1WgjGPi58i1sW8QQKyRFUx68fg 8W+RohGbyMcjHAmZURrhKcexSeCPfDuoO5RtFqPWVJEgPQqVoaQxtYa6CyDpTReKAGJna WD/P+brDSSxnmtBBo6bo/eE9QC6egTmtkiOlwac71Uzeu4d14ki6otZ+BEU/AbqcBYVvV F/O1RNMxkSMa/WJto90amfSsjfyneSU1LJZXLyFulGUfgSW5dNGT9UWgbDB6nLDCyKwrt KQ6I9e86co52NvGF6eugw2YaHDvd6ecH1AlsrzDXzRee/Crjx4e7HBvFV3ldbNhKr0Zy7 L+KLPvswuJ8UlOtPGG2bSwiiIjzvpxZYo05/Gw308mu1WC4P7Eu4GWZs0moEcNbJx8N82 Mpm+FIWY7WgINDbA7D7trqVnCUVFrqZ93dvn4W9bg2eL5v4GOvXggawePouS96HPvOuRR IL9YI0HLkLQExG2fU9JEcwgXKmNjpj1ic/2Y1EN00Mz8ToCgy62aPoPcym2KGaOSSMrJd 1/H4Np1QKpn1Lf+gDpLV4f5/DyuTj0uUskFsncOk5P6fwsCl5Idg0zZ9lF92WwU=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <stefano@xxxxxxxxxxxxxx>
- Delivery-date: Wed, 19 Feb 2025 11:04:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-02-19 11:44, Andrew Cooper wrote:
On 19/02/2025 10:00 am, Jan Beulich wrote:
struct mctelem_ent is opaque outside of mcetelem.c; the cookie
abstraction exists - afaict - just to achieve this opaqueness. Then it
is irrelevant though which kind of pointer mctelem_cookie_t resolves
to.
IOW we can as well use struct mctelem_ent there, allowing to remove
the
casts from COOKIE2MCTE() and MCTE2COOKIE(). Their removal addresses
Misra C:2012 rule 11.2 ("Conversions shall not be performed between a
pointer to an incomplete type and any other type") violations.
No functional change intended.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/9181587757
Eclair does appear to be happy with this approach (assuming I stripped
down to only checking R11.2 correctly, and making it fatal).
The analysis settings are correct.
For the change itself, it's an almost identical binary, differing only
in the string section which I expect means some embedded line numbers.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
