Re: [PATCH v2 3/5] x86/smp: perform disabling on interrupts ahead of AP shutdown

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Feb 10, 2025 at 11:24:58AM +0100, Jan Beulich wrote:
> On 06.02.2025 16:06, Roger Pau Monne wrote:
> > Move the disabling of interrupt sources so it's done ahead of the offlining
> > of APs.  This is to prevent AMD systems triggering "Receive accept error"
> > when interrupts target CPUs that are no longer online.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Changes since v1:
> >  - New in this version.
> 
> Ah, you decided to effectively split the original patch.
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with a question:
> 
> > --- a/xen/arch/x86/smp.c
> > +++ b/xen/arch/x86/smp.c
> > @@ -374,6 +374,8 @@ void smp_send_stop(void)
> >          smp_call_function(stop_this_cpu, &stop_aps, 0);
> >  
> >      local_irq_disable();
> > +    disable_IO_APIC();
> > +    hpet_disable();
> 
> Is this then taking care of the bogus error interrupt observing ESR=0x00?

This, with the extra commits that follow should prevent the error from
triggering yes.  With all patches in the series applied I'm no longer
able to see the ESR=0x00 message.

Thanks, Roger.