Re: [PATCH v5 05/44] x86/boot: introduce struct boot_module

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 10/9/24 11:17, Jan Beulich wrote:
> On 06.10.2024 23:49, Daniel P. Smith wrote:
> > @@ -302,6 +304,13 @@ static struct boot_info __init 
> > *multiboot_fill_boot_info(unsigned long mbi_p)
> >           bi->memmap_length = mbi->mmap_length;
> >       }
> >   
> > +    /*
> > +     * This will iterate over all modules to include an extra mb module, which
> > +     * should have been reserved to hold an entry for Xen.
> > +     */
> > +    for ( i = 0; i <= bi->nr_modules; i++ )
> > +        bi->mods[i].mod = &mods[i];
> I find the comment difficult to follow / match with code here and elsewhere.
> How about "Iterate over all modules, including the extra one which should
> have been reserved for Xen itself"?
Okay.

v/r,
dps