Re: [PATCH v6 2/4] x86/ucode: refactor xen-ucode to utilize getopt

[Fouad Hilly <fouad.hilly@xxxxxxxxx>]

On Thu, Jul 25, 2024 at 9:41 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:

On 25.07.2024 10:27, Fouad Hilly wrote:
> @@ -71,12 +72,29 @@ static void show_curr_cpu(FILE *f)
>      }
>  }
> 
> +static void usage(FILE *stream, const char *name)
> +{
> +    fprintf(stream,
> +            "%s: Xen microcode updating tool\n"
> +            "options:\n"
> +            "  -h, --help            display this help\n"
> +            "  -s, --show-cpu-info   show CPU information\n"
> +            "Usage: %s [microcode file | options]\n", name, name);

Oh, and: While I gave this precise layout as an outline, it wasn't really
meant to be used literally. Note how "microcode" and "file" now suggest
there need to be two separate command line elements. Perhaps using
"microcode-file" instead may already make this less ambiguous.

Yes indeed, I will fix in v7:

  static void usage(FILE *stream, const char *name)

{

    fprintf(stream,

            "%s: Xen microcode updating tool\n"

            "Usage: %s [options | microcode-file]\n"

            "options:\n"

            "  -h, --help                       display this help\n"

            "  -s, --show-cpu-info              show CPU information\n"

            "  -f, --force <microcode-file>     skip certain checks; do not\n"

            "                                   use unless you know exactly\n"

            "                                   what you are doing\n",

            name, name);

    show_curr_cpu(stream);

}

Jan

Thanks,

Fouad