Re: [PATCH v2] Arm: correct FIXADDR_TOP

[Julien Grall <julien@xxxxxxx>]

Hi,

On 13/08/2024 12:57, Michal Orzel wrote:
> On 13/08/2024 13:49, Jan Beulich wrote:
> > While reviewing a RISC-V patch cloning the Arm code, I noticed an
> > off-by-1 here: FIX_PMAP_{BEGIN,END} being an inclusive range and
> > FIX_LAST being the same as FIX_PMAP_END, FIXADDR_TOP cannot derive from
> > FIX_LAST alone, or else the BUG_ON() in virt_to_fix() would trigger if
> > FIX_PMAP_END ended up being used.
> >
> > While touching this area also add a check for fixmap and boot FDT area
> > to not only not overlap, but to have at least one (unmapped) page in
> > between.
> >
> > Fixes: 4f17357b52f6 ("xen/arm: add Persistent Map (PMAP) infrastructure")
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Committed.

Cheers,

--
Julien Grall