[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v5 02/13] x86/monitor: guard altp2m usage
- To: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
- From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Date: Tue, 30 Jul 2024 10:35:19 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1722350159; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=D1ebpLyx8gR86eeQvtJ6wU+dy9ju+XdkIf9IVMlzmQo=; b=IWQTTMtKgJiM4J0eiFhshBJLWZe0rQNAeiMKhosaib/P8l4ExCJQi9xUWyY7SoJDXUEoP6liB3DxjLCUFqemPS3T3FILMChF9gV5I76nkJewYbfk6lEZ/rz3cRivaXM3jKt3V3vJfMwBDeloZwDf8WtFHllzxpbmDilY7z7gQt4=
- Arc-seal: i=1; a=rsa-sha256; t=1722350159; cv=none; d=zohomail.com; s=zohoarc; b=hfCuvxWjoiiZ59yTIS/+pCEnZVhZFIjM8aPkjTWr1uW8sldNF7KLBAHZDlMeOXnHfmLCZuGoQDwocAr+YEUTZHejpwVUPxbWSKydMk8EVAZftB7/9MWTAcz/3x7mK5KLdN01B5o3aktZE9W4d8SkMSxiDH1vvBICV1FWqAXBf8E=
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>
- Delivery-date: Tue, 30 Jul 2024 14:36:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 30, 2024 at 6:18 AM Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx> wrote:
>
> Explicitly check whether altp2m is on for domain when getting altp2m index.
> If explicit call to altp2m_active() always returns false, DCE will remove
> call to altp2m_vcpu_idx().
>
> p2m_get_mem_access() expects 0 as altp2m_idx parameter when altp2m not active
> or not supported, so 0 is a fallback value then.
>
> The puspose of that is later to be able to disable altp2m support and
"purpose" misspelled here
> exclude its code from the build completely, when not supported by target
> platform (as of now it's supported for VT-d only).
Probably wanted to say "VT-x only" here
>
> Also all other calls to altp2m_vcpu_idx() are guarded by altp2m_active(), so
> this change puts usage of this routine in line with the rest of code.
>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
With the commit message fixed (probably could be done when applied):
Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
|
