[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/arm: stack check instrumentation
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Mon, 29 Jul 2024 15:40:38 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5aABjyKaClT8pPIpFqzEgIwi5aX84o/quFhqE1As6tU=; b=QDjik1R97qvlNdecYYS075KNI/+/JO9q8PxxGqpO/MsLNgc1FR6qINZLWD6/LlHVnocszkAbAyAw/PzbVTLDX0JX70PGQdus8iv0uXsGtAauqgWqbAGp2KM1NPi4ukgpMylMFqOAW/PGtKDolsbg0m0UJ87EgZ0z7I2F7Xr3qcRkwyPBoz/olpfTp3skZz/I11wRfIg3ACjxDi3Ni3WK+Do/up7W4kbgLMIE2Vh4jgIArqPGTJIarD4nFK3jH8LjeW8Gfu1M3DaZQlscRu+dLVPEIcp7TZVP7fNxDan9nALRU3Cgw9ZGvS7w0ouW9l2JxiBsrq9Ih6fDxR8yY2j8Rg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FuIpwuky7k0urVYn0m/HT2uSSrNcWXbtabZrvZVonA2GXgdCSHekZ/UJqJPgy8+TOrOwY06+nyZnlc+4Kk4XuuBHre/O/w3gcRnli2wyEaJlLwF05gR9i+lxEL7uwPzvj7H9D3iWMII/R2vzd6Jkccx6Nm5pOWufd2Nk8CDMWPONEjdcIyvmHtLMFyHvO6gapnP9FRmZd34Bb904rGAB9OTAmTifwttV6lO1oQXaMZzTRSCT9WB4emPbndPgNy9UIW8lljIHgZnFXtwOlv/C//kXre1LPx1pGAS/jtXNJ3Klt0+51Es9sCEfzetKHh7594CgoeqUdzNb+VO40alVyw==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 29 Jul 2024 19:41:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 7/29/24 14:50, Julien Grall wrote:
> Hi again,
>
> On 29/07/2024 15:24, Stewart Hildebrand wrote:
>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
>> index aac6c599f878..b4890eec7ec4 100644
>> --- a/xen/arch/arm/traps.c
>> +++ b/xen/arch/arm/traps.c
>> @@ -2325,6 +2325,51 @@ void asmlinkage leave_hypervisor_to_guest(void)
>> arm_smccc_1_1_smc(ARM_SMCCC_ARCH_WORKAROUND_2_FID, 0, NULL);
>> }
>> +#ifdef CONFIG_DEBUG
>> +DEFINE_PER_CPU(unsigned int, stack_check_nesting);
>> +DEFINE_PER_CPU(unsigned char *, stack_base);
>
> While looking at the code, I just realized that this should be equivalent to
> current->arch.base.
current->arch.stack
That's true only after the idle vcpu stacks have been allocated.
> So do we actually need stack_base?
This is a way to enable stack instrumentation much earlier during boot
when we are still using the static boot stack.
|
