Re: [PATCH 4/4] mini-os: remove sanity_check()

[Jürgen Groß <jgross@xxxxxxxx>]

On 25.07.24 00:44, Samuel Thibault wrote:
> Hello,
>
> Jürgen Groß, le mar. 23 juil. 2024 08:36:13 +0200, a ecrit:
> > On 22.07.24 23:35, Samuel Thibault wrote:
> > > Juergen Gross, le lun. 22 juil. 2024 17:01:41 +0200, a ecrit:
> > > > Remove the sanity_check() function, as it is used nowhere.
> > > >
> > > > Since any application linked with Mini-OS can't call sanity_check()
> > > > either (there is no EXPORT_SYMBOL for it), there is zero chance of
> > > > breaking any use case.
> > > Don't we still want to keep it around, at least as formal documentation
> > > of the expected status of the list?
> > Hmm, is it really worth the extra code?
> I have already seen such kind of piece of code getting very convenient
> when tracking odd bugs.
What about putting it under CONFIG_TEST then?

This would keep it in the source and it would even be compile tested by
a simple "make testbuild", which is a simple test I'm always doing
before submitting a patch.


Juergen