Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote:
> "$dev" needs to be set correctly for backendtype=phy as well as
> backendtype=tap.  Move the setting into the conditional, so it can be
> handled properly for each.
> 
> (dev could be captured during tap-ctl allocate for blktap module, but it
> would not be set properly for the find_device case.  The backendtype=tap
> case would need to be handled regardless.)
> 
> Fixes: 6fcdc84927 ("hotplug: Restore block-tap phy compatibility")

Do you mean f16ac12bd418 ("hotplug: Restore block-tap phy compatibility") ?

> Fixes: 76a484193d ("hotplug: Update block-tap")
> 
> Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

With the fixes tag fix:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
> Tested with backendtype=tap & tapback and backendtype=phy & blktap
> module.

Thanks for the extra testing.

Cheers,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech