Re: [PATCH v2 4/8] xen/riscv: setup fixmap mapping

[Julien Grall <julien@xxxxxxx>]

On 23/07/2024 13:58, oleksii.kurochko@xxxxxxxxx wrote:
> Hi Julien,
Hi Oleksii,

> On Sun, 2024-07-21 at 09:46 +0100, Julien Grall wrote:
> > > +/* Fixmap slots */
> > > +#define FIX_PMAP_BEGIN (0) /* Start of PMAP */
> > > +#define FIX_PMAP_END (FIX_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of
> > > PMAP */
> > ... here is seems to be inclusive. Furthermore if you had 32-bit
> > address
> > space, it is also quite easy to have to create a region right at the
> > top
> > of it. So when END is exclusive, it would become 0.
> >
> > So on Arm, we decided to start to get rid of "end". I would consider
> > to
> > do the same on RISC-V for new functions.
> I assume that you wrote here just as an example of confusion occurs
> because of using *_END but just to be clear I have to leave
> FIXMAP_MAP_END as-is because it is used now by common code.
Indeed. FIXMAP_PMAP_END should stay for now.

Cheers,

--
Julien Grall