[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.19 v2] x86/physdev: Return pirq that irq was already mapped to
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Mon, 8 Jul 2024 11:47:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTfjQEt2RlMCIZuIrG6hLdyh+Dxp52qrKCycrBZ3IV0=; b=KbhEYPJm7tt+wUOySz5oWt6zVUd0OjvfoUdUM5+dMrVFBdGMxK0jYwcQYf8n6ITLBn0uo0Hwjr6F6QfIoYiqR3yWoali1s41iHdVLp803YPZWEDOD7wzbnOLcJQcKeQ+yeIVEzmnu0cl1GXo9gfaJvmpxNn9+YDOS1/VF8ZN2486FmoUP5tzZ6NJakXPRY4Ku7IWSR0IvASgtppV5RQwxZKBXrb1nWOpGQnninfH87KT/82qr90xtB+OTJ/E2o0Fvgo8j5z5N4KkZjtdg3yqMqCmjEtC/4IL9zf5vq+HFEPws5FlsXkGAMbUA/RPNKvw7ljd8UdhuBldNQ5oZCxy1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SU5vxqUDYtygq9a0YUj5G28ynUSsqDFQ6Vj1rVwFnu3RUmaEj91bjURcYGXYctIWjCaQebOqlBT+IgjgpTj6/Q4B7FOiwY5RFMbv2kzsq9aqLWanV1+/tPhcGTJpqK+Bg90h0Q+PZB+ahJq3JbEyRQk+VzHTnA/5rB18HpbfFe0422+vQ3Y9WV9ilXDiLfrbFgWKZyyVmv76R45CuN9w6BVX2Y3PvHLP4hLbmLjylIomZiA5hdtSDyNhsxDBV/JTtTLqjSaY/L5RuRtOH5gFiGsqwGFHw5r75SEtpt1KR1H1PqEZ78p4pcu7bajpHbHyoNfD+CGQy8gyj65w0P8Qzg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 08 Jul 2024 11:47:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHa0Q2QSY6Mwz0FMECG0gX/YHD3QrHsoiAAgACaZIA=
- Thread-topic: [PATCH for-4.19 v2] x86/physdev: Return pirq that irq was already mapped to
On 2024/7/8 18:32, Andrew Cooper wrote:
> On 08/07/2024 9:04 am, Jiqian Chen wrote:
>> Fix bug introduced by 0762e2502f1f ("x86/physdev: factor out the code to
>> allocate and
>> map a pirq"). After that re-factoring, when pirq<0 and current_pirq>0, it
>> means
>> caller want to allocate a free pirq for irq but irq already has a mapped
>> pirq, then
>> it returns the negative pirq, so it fails. However, the logic before that
>> re-factoring is different, it should return the current_pirq that irq was
>> already
>> mapped to and make the call success.
>>
>> Fixes: 0762e2502f1f ("x86/physdev: factor out the code to allocate and map a
>> pirq")
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> As a minor note, we treat Fixes: as a tag like all the others, so tend
> not to have a blank line between it an the SoB.
Learned it, thank you!
>
> Can be fixed on commit - no need to resend.
>
> ~Andrew
--
Best regards,
Jiqian Chen.
|
