Re: [PATCH for-4.20] xen/arm: dom0less: Add #redistributor-regions property to GICv3 node

[Julien Grall <julien@xxxxxxx>]

Hi,

On 04/07/2024 11:39, Luca Fancellu wrote:
> > On 4 Jul 2024, at 08:54, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> >
> > Dom0less domain using host memory layout may use more than one
> > re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen
> > will add them in a "reg" property of a GICv3 domU node. Guest needs to
> > know how many regions to search for, and therefore the GICv3 dt binding
> > [1] specifies that "#redistributor-regions" property is required if more
> > than one redistributor region is present. However, Xen does not add this
> > property which makes guest believe, there is just one such region. This
> > can lead to guest boot failure when doing GIC SMP initialization. Fix it
> > by adding this property, which matches what we do for hwdom.
> >
> > [1] Linux: 
> > Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> >
> > Fixes: 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for 
> > GICv3")
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > ---
> Looks good to me!
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall