Re: [PATCH v14 7/9] xen/riscv: use .insn with operands to support the older gas

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Tue, 2024-07-02 at 14:02 +0200, Jan Beulich wrote:
> On 02.07.2024 13:01, Oleksii Kurochko wrote:
> > Support for specifying "raw" insns was added only in 2.38.
> > To support older version it would be better switch to .insn
> > with operands.
> > 
> > The following compilation error occurs:
> >   ./arch/riscv/include/asm/processor.h: Assembler messages:
> >   ./arch/riscv/include/asm/processor.h:70: Error: unrecognized
> > opcode `0x0100000F'
> > In case of the following Binutils:
> >   $ riscv64-linux-gnu-as --version
> >   GNU assembler (GNU Binutils for Debian) 2.35.2
> > 
> > Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> > Andrew,
> > 
> > Could you please take a look if you are okay with suggested
> > changes.
> > 
> > Thanks in advance.
> 
> I won't wait for too long for a reply here (perhaps until EOD
> tomorrow), as
> I expect the change to be pretty uncontroversial. However, to put it
> in at
> this point I'll need a release ack first anyway.
Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

~ Oleksii