Re: [PATCH v8 06/13] tools: add support for cache coloring configuration

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, May 02, 2024 at 06:55:26PM +0200, Carlo Nonato wrote:
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index 41252ec553..ff80625bd6 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -726,6 +726,19 @@ int libxl__domain_make(libxl__gc *gc, 
> libxl_domain_config *d_config,
>              /* A new domain now exists */
>              *domid = local_domid;
>  
> +            ret = xc_domain_set_llc_colors(ctx->xch, local_domid,
> +                                           b_info->llc_colors,
> +                                           b_info->num_llc_colors);
> +            if (ret < 0 && errno == EOPNOTSUPP) {
> +                if (b_info->num_llc_colors > 0)
> +                    LOGED(WARN, local_domid,
> +                          "LLC coloring not enabled in the hypervisor");

Why is this only a "warning"?

> +            } else if (ret < 0) {
> +                LOGED(ERROR, local_domid, "LLC colors allocation failed");
> +                rc = ERROR_FAIL;
> +                goto out;
> +            }
> +
>              rc = libxl__is_domid_recent(gc, local_domid, &recent);
>              if (rc)
>                  goto out;

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech