[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()
- To: Michael Kelley <mhklinux@xxxxxxxxxxx>
- From: "hch@xxxxxx" <hch@xxxxxx>
- Date: Thu, 27 Jun 2024 17:25:13 +0200
- Cc: Petr Tesařík <petr@xxxxxxxxxxx>, "hch@xxxxxx" <hch@xxxxxx>, "robin.murphy@xxxxxxx" <robin.murphy@xxxxxxx>, "joro@xxxxxxxxxx" <joro@xxxxxxxxxx>, "will@xxxxxxxxxx" <will@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "oleksandr_tyshchenko@xxxxxxxx" <oleksandr_tyshchenko@xxxxxxxx>, "m.szyprowski@xxxxxxxxxxx" <m.szyprowski@xxxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 27 Jun 2024 15:25:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jun 27, 2024 at 02:59:03PM +0000, Michael Kelley wrote:
> Conceptually, it's still being used as a boolean function based on
> whether the return value is NULL. Renaming it to swiotlb_get_pool()
> more accurately describes the return value, but obscures the
> intent of determining if it is a swiotlb buffer. I'll think about it.
> Suggestions are welcome.
Just keep is_swiotlb_buffer as a trivial inline helper that returns
bool.
|