Re: [PATCH] tools/xentop: add option to display dom0 first

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Jan 31, 2024 at 06:51:34PM +0100, Cyril Rébert wrote:
> Add a command line option to xentop to be able to display dom0 first, on top 
> of the list.
> This is unconditional, so sorting domains with the S option will also ignore 
> dom0.
> 
> Signed-off-by: Cyril Rébert (zithro) <slack@xxxxxxxxx>

Hi Cyril,

Your patch looks like a good idea, but xentop segv without '-z' now, when
there are guest running.

Revelant part of a backtrace:
#0  xenstat_domain_name (domain=0x121) at xenstat.c:344
344             return domain->name;
#6  0x00006344dd283651 in top () at xentop.c:1209
        i = 2
        num_domains = 2
        sort_start = 1
        sort_count = <optimized out>
        dom0_index = <optimized out>
1209            qsort((domains+sort_start), (num_domains-sort_count), 
sizeof(xenstat_domain *),
1210                  (int(*)(const void *, const void *))compare_domains);


Also, could you update the man page? Here "docs/man/xentop.1.pod""

Thanks,

-- 
Anthony PERARD