Re: [XEN PATCH v2] xen: move declaration of first_valid_mfn to xen/numa.h

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 20 Dec 2023, Jan Beulich wrote:
> On 19.12.2023 02:48, Stefano Stabellini wrote:
> > On Mon, 18 Dec 2023, Nicola Vetrini wrote:
> >> Such declaration is moved in order to provide it for Arm and PPC,
> >> whilst not violating MISRA C:2012 Rule 8.4 in common/page_alloc.c:
> >> "A compatible declaration shall be visible when an object or
> >> function with external linkage is defined".
> >>
> >> Signed-off-by: Julien Grall <julien@xxxxxxx>
> >> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> 
> I was about to submit my replacement, just to find that this was committed
> during my night. I have to admit that I absolutely do not understand the
> need for rushing here; I thought I said quite clearly that I will come
> forward with a patch dealing with two issues in one go. Now I need to go
> and re-base my change, because all of what this patch touches is also
> touched by my change, as the 2nd issue (the pointless presence of
> asm/numa.h and the need for RISC-V to introduce a 3rd instance if nothing
> is done up front) is still there.


Hi Jan,

Sorry about that. As you might have noticed I typically wait at least
1-2 days but this time I wasn't sure I would be able to come back online
before the Holidays and I was trying to clean things up. I apologize.