[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 20 Dec 2023 08:50:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bXWKnpdT2bKUIYWndABCqXCuVJIlf9WMCBRypwQQKAA=; b=UPw7GoLXfJbgowVtqjMj2hViIARXGwHIBSV/6E4p+iAc9sQl+RIAoE6+NEWr1+0rCvvfOkXK1pWB/WOJgj8PTaREokil2AZn+kKZtD2wvZkoJw0TpwSNMFAAxDREAEk0UFqiFMpg2XOt3hZjFjOpgSNHRjH6WC9iMx0b+BsJeZJa+9Lw84SqSfjy5A0beeGkAn1zoqZ4QK5KFSUjKZNwEJpLyJivo5OQJg/jIO2JF8v4umYA8Eoi99D1i4AlF2cTGVLcJpjxFDW3t7kqSg3jGcNrFdyaDZoNLnea3k9psl6vnoCsW6ngwryr7Gen8NcM+NFgFvrxbEjBHcnKYWBHyg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bXWKnpdT2bKUIYWndABCqXCuVJIlf9WMCBRypwQQKAA=; b=ifocj3bRFQZzC4Ae5HNWLXHFplEO5mNLHw2q6QV/aExxdWwu+JraTMlttzSPekf1JhctedT48at2ElDz5hBomEk6HBgKcEsy+EzsegHZgdfoQ0gFQmpj1wEHGnskrPkI/lGV1SnAxVWZ1ut2yEzp8YZ0wkbxUNUlrVVrWY4ByJ7ciRBuPVVZEXfsQCJ3W7h6bZ1syHJB8GpOjWKEezmiZv7ZM/E23yENnZIfWY9EMPK9rnwqLrbq7c88yz3b2b4e6YiudYPB+OfG10zzerplokbc+u6Cuy2Z5/QOjeAv3EUTm+4I4hqqBxg8PUwZ7A8PV+NEumBkyQkOsyvTQPll5g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eAkkoEGHJ1OndEerbldrDJ3yufWfxMcKPSS6OTIY35xTh3DgJJKoIKUCfAkQGH4awfkGz2Uc9RtWFzOT1PvMglMVX1QN7EyP/FMhd7m9W//evrv/fw2J1O1jd3femJA7gimdLsR6C/UD6WRjUfkobzJZhhdmA1uCxlWAgT3LDDBahHLo+g79/TJDXz7456Ser+1nlpQ+IFOSq7tudptGEsH+eHxQSFfFDQmlQedD5sIx/7pvMe6gyl9WL4C0GMxWNXm2VCn34vPqTTphUdKAFM6RAHqjq2RunP6yA5DdtuV7nYQs5z6UhUC77gjBkiUVhuyg1lcHnUROF85bRX0LzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iGr2usywVFMI7oYK0/ggQ+kipuxLLdXvdIqaYlq97TTkpwCQjni+UCJUQpnHfKZ3cBJsQgEBgvtzLbo0ibOl75ESaw1UvkeW1XceaGIH2vkmRm7LXVkVeJwHwJsEzuddILzzgtDA1Q0X68lp8Pwg7UTuFVfsUqUFp5Tb4MuUQgpia5NqsB3vo35pFr+yk4LwduwGw4VRLpEFi4CojWOadN8qGXdIcELb0WLfrS8omusUo4U7ebuKNru8iTVfe53bgx1Z0VbZ6sigcJ4ue3ELorrBhFP+9iT2FknL7i41B6U0fY0UNyKXiJjtDXpQJnY8gwwXdSBanJdaybkRUI07SA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 20 Dec 2023 08:50:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMmldSNcDtDpNs0m0RNrxIeAVZrCwcdKAgAABGYCAANv4gIAAjRKAgAACT4A=
- Thread-topic: [XEN PATCH] xen: add acmacros.h to exclude-list.json
> On 20 Dec 2023, at 08:41, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 20.12.2023 01:17, Stefano Stabellini wrote:
>> On Tue, 19 Dec 2023, Luca Fancellu wrote:
>>>> On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>>> wrote:
>>>> On 2023-12-19 11:51, Nicola Vetrini wrote:
>>>>> On 2023-12-19 11:37, Jan Beulich wrote:
>>>>>> On 19.12.2023 10:02, Nicola Vetrini wrote:
>>>>>>> --- a/docs/misra/exclude-list.json
>>>>>>> +++ b/docs/misra/exclude-list.json
>>>>>>> @@ -209,6 +209,10 @@
>>>>>>> "rel_path": "include/acpi/acglobal.h",
>>>>>>> "comment": "Imported from Linux, ignore for now"
>>>>>>> },
>>>>>>> + {
>>>>>>> + "rel_path": "include/acpi/acmacros.h",
>>>>>>> + "comment": "Imported from Linux, ignore for now"
>>>>>>> + },
>>>>>> Together with what's already there (in context), wouldn't it better be
>>>>>> the entire directory then which is excluded, or at least all
>>>>>> include/acpi/ac*.h collectively (and perhaps also
>>>>>> include/acpi/platform/ac*.h)?
>>>>>> Jan
>>>>> +Cc Luca Fancellu
>>>>> Sure. I wasn't certain which files are imported from ACPI CA and which
>>>>> aren't.
>>>>> I'm also not sure whether "include/acpi/ac*.h" would be properly
>>>>> recognized by other tooling that uses exclude-list.json (only cppcheck I
>>>>> think). I Cc-ed Luca Fancellu on this.
>>>>
>>>> It occurred to me that it's surely ok to use "include/acpi/ac*" and
>>>> "include/acpi/platform/ac*".
>>>
>>> Yes I think it’s fine, it just come to my mind now that this could have the
>>> risk that if
>>> another file is added with ‘ac' prefix, even if it could be subject to
>>> MISRA compliance,
>>> it will be excluded.
>>>
>>> If that risk is negligible for the maintainer of that part, then it’s fine.
>>
>> I think it is OK either way, I'll let Jan pick his preference.
>
> It hasn't become clear to me what the benefit would be of omitting the
> trailing .h.
Yes, with the extension is better, the same as we already do here:
[...]
{
"rel_path": "common/un*.c”,
"comment": "unlz4.c implementation by Yann Collet, the others un* are from
Linux, ignore for now"
},
[...]
|
